Error comparing VCF files #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ickstart target to Makefile and run as part of build process
michaeltneylon
approved these changes
Jan 5, 2021
Codecov Report
@@ Coverage Diff @@
## develop #160 +/- ##
========================================
Coverage 76.01% 76.01%
========================================
Files 18 18
Lines 1901 1901
========================================
Hits 1445 1445
Misses 456 456
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the VCF data type, VCF files are made comparable using a grep command that filters out comment lines. If the file is empty or has no header lines, grep exits with a return code of 1, which should be allowed as valid.
This is the root cause of #158