Some Puffin http cleanup #236
Open
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frame_view var is only added for use scope_collection member. This change to directly use a ScopeCollection.
replace linked parameter scope_collection + bool send_all_scopes with an Option<ScopeCollection>
gwen-lg
force-pushed
the
puffin_http_cleanup
branch
from
d1764f4 to
51e56cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Some small cleanup of scopes collection management in serialization and
puffin_http.FrameViewvar byScopeCollectioninPuffinServerImpl, the other members of FrameView wasn't used.&ScopeCollection+ a boolean.I think this changes make the code easier to understand.