Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <hr> tag to the Contact page #171

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add <hr> tag to the Contact page #171

merged 1 commit into from
Oct 24, 2023

Conversation

WarningImHack3r
Copy link
Member

@WarningImHack3r WarningImHack3r commented Oct 24, 2023

1-line PR, quick and easy: I just learned in a Tweet that Chrome 119, as well as Safari 17, now support <hr> tags into <select>s.

I instantly thought we could use it in the only place I've ever used a <select>: the Contact page.
It is not only a gimmick that I wanna use because I learned its existence: it does make sense to separate "No budget" from the rest.

It also doesn't cost a thing: on an unsupported/outdated browser, it will just not work, so no issue on that side! It will naturally become available to up-to-date users, and older browsers won't make a difference before/after this PR.

Result

So here we are, one line of change, 4 characters, here is the result:

Before After
Before After

Note

Despite the support coming in Chrome 119, these screenshots come from Arc, which still uses Chromium 118, as 119 is still nightly. It seems to already be supported I don't know!

@WarningImHack3r WarningImHack3r merged commit ad05900 into main Oct 24, 2023
6 checks passed
@WarningImHack3r WarningImHack3r deleted the hr-in-contact branch October 24, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants