This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
Fix for wrong value update after input change #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed (double) conflicting value update for the price slider.Added flag to check if price slider update came from input fields. To fix the following bug:The removed method updated the fields with the old values and was conflicting with the value update in the input change handler here: https://github.com/EmicoEcommerce/Magento1Tweakwise/blob/master/skin/frontend/base/default/emico_tweakwise/js/AttributeSlider.js#L289And in case of using the slider to adjust the values, the value update here: https://github.com/EmicoEcommerce/Magento1Tweakwise/blob/master/skin/frontend/base/default/emico_tweakwise/js/AttributeSlider.js#L169
Added a flag to check if update comes from input fields change, to make sure the lower and upper value are not updated double and with the old values from the
onChange(values)
method.