Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Fix for wrong value update after input change #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

podenemus
Copy link
Contributor

@podenemus podenemus commented Apr 7, 2020

Removed (double) conflicting value update for the price slider. Added flag to check if price slider update came from input fields. To fix the following bug:

The removed method updated the fields with the old values and was conflicting with the value update in the input change handler here: https://github.com/EmicoEcommerce/Magento1Tweakwise/blob/master/skin/frontend/base/default/emico_tweakwise/js/AttributeSlider.js#L289
And in case of using the slider to adjust the values, the value update here: https://github.com/EmicoEcommerce/Magento1Tweakwise/blob/master/skin/frontend/base/default/emico_tweakwise/js/AttributeSlider.js#L169

Added a flag to check if update comes from input fields change, to make sure the lower and upper value are not updated double and with the old values from the onChange(values) method.

@podenemus podenemus changed the title Remove double update of input values on change Fix for wrong value update after input change Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant