chore: Cargo shell script to support +nightly #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be more convenient than having a separate devShell for nightly tasks (which still wouldn't support the `+nightly` argument). It works for me to run `cargo test` and `scripts/run_tests.sh`. Not familiar with the repo so don't know if other workflows might break.
alxiong
changed the title
alxiong
reviewed
Nov 11, 2023
There was a problem hiding this comment.
I like this idea!
but I got this error locally:
$ cargo +nightly fmt
env: ‘Fusion.app/Contents/Public:/opt/X11/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/alex/.config/.foundry/bin:/Users/alex/.foundry/bin:/Users/alex/.config/.foundry/bin:/Users/alex/work/jellyfish/target/debug:/Users/alex/work/jellyfish/target/release’: No such file or directory
|
@alxiong Should work now. Forgot to quote the PATH so it broke with spaces in the PATH. |
alxiong
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be more convenient than having a separate devShell for
nightly tasks (which still wouldn't support the
+nightlyargument).It works for me to run
cargo testandscripts/run_tests.sh.Not familiar with the repo so don't know if other workflows might break.