Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use required-features instead for benches #412

Merged
merged 1 commit into from
Nov 13, 2023
Merged

ci: use required-features instead for benches #412

merged 1 commit into from
Nov 13, 2023

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Nov 13, 2023

Description

I've been receiving CI failure (e.g. here) for the periodic-check.yml workflow, due to the build failure on some of our bench code.

As it turns out, whenever we want to use testing srs api, we use !#[features="test-srs"] in the code, which leads the compiler that by default doesn't build with this feature flag on to mistakenly assume there's no main() function in these bench code, thus erroring.

The proper way to do it, is simply add required-features in the Cargo.toml.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@alxiong alxiong added P-low Low priority T-bench Type: benchmark & profiling labels Nov 13, 2023
@alxiong alxiong requested review from mrain and ggutoski November 13, 2023 03:43
@alxiong alxiong self-assigned this Nov 13, 2023
@alxiong alxiong changed the title bench: use required-features instead for benches ci: use required-features instead for benches Nov 13, 2023
Copy link
Contributor

@tessico tessico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!

@alxiong alxiong merged commit fff9e5b into main Nov 13, 2023
3 of 5 checks passed
@alxiong alxiong deleted the fix-ci branch November 13, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-low Low priority T-bench Type: benchmark & profiling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants