Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tagged base64 #414

Merged
merged 1 commit into from
Nov 14, 2023
Merged

chore: update tagged base64 #414

merged 1 commit into from
Nov 14, 2023

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Nov 14, 2023 •
edited
Loading

Description

Update tagged base 64, fixing serde_json::from_value bug

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@jbearer jbearer changed the title Update tagged base64 chore: update tagged base64 Nov 14, 2023
ggutoski
ggutoski approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ggutoski ggutoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it a workspace dependency, too.

@jbearer jbearer merged commit 1a9db50 into main Nov 14, 2023
5 of 6 checks passed
@jbearer jbearer deleted the update/tagged-base64 branch November 14, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggutoski ggutoski ggutoski approved these changes

@mrain mrain Awaiting requested review from mrain mrain is a code owner

@chancharles92 chancharles92 Awaiting requested review from chancharles92

@alxiong alxiong Awaiting requested review from alxiong alxiong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbearer @ggutoski