Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to have per item transaction permissions #5585

Closed
wants to merge 2 commits into from
Closed

Adds the ability to have per item transaction permissions #5585

wants to merge 2 commits into from

Conversation

NicholasJBond
Copy link

@NicholasJBond NicholasJBond commented Nov 25, 2023

Resolves
#2212

Details
Adds the permissions essentials.item.<free|buy|sell>.<itemName>.

Players still need the permissions essentials.sell.<hand|inventory> and essentials.signs.<free|buy|sell>.use depending on which method they sell their items.

Example
A player needs essentials.item.sell.redstone in order to sell redstone(sign or command).

To keep existing behaviour
Set permission to essentials.item.<free|buy|sell>.* to allow all types or items to be sold.
Not sure if this should be added into the config file for example as: perItemTransactionPermissions: false or if server admins could add the above permission into their permission manager.

OS: Windows

Java version: 17.0.9

Minecraft 1.20.2

Paper Version used gradlew build :runServer

Adds the permission: essentials.sell.item.<item name>.
For example, a player needs essentials.sell.item.redstone in order to sell redstone using /sell or a sell sign.

Set permission to essentials.sell.item.* to allow all types or items to be sold.
Changed permissions to essentials.item.<buy|sell|free>.<itemName>
@imDaniX
Copy link
Contributor

imDaniX commented Dec 6, 2023

Not sure if this should be added into the config file for example as: perItemTransactionPermissions: false or if server admins could add the above permission into their permission manager.

I'd say this should, since this changes the current behavior.

@pop4959 pop4959 added the status: waiting on author Pull requests that require changes from the author in order to merge. label Dec 10, 2023
@pop4959
Copy link
Member

pop4959 commented Dec 10, 2023

Similar comments as the other closed issue, appreciate this but needs to be more configurable, also have concerns around hard-coded messages, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting on author Pull requests that require changes from the author in order to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants