fix timezone env TZ #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, now please run (Yes, I agree is a bit weird to have auto-generated files be checked directly into the codebase, but this makes it convenient for Open WebUI users to copy-paste directly from a single file when installing the tool or function. See the dev guide here.) |
For e.g, with $TZ="Asia/Chongqing" on host "TZ=" + time.tzname[0] will set TZ=CST, which restult in utils such as 'date' output UTC time instead of CST time because "CST" isn't a valid timezone. This fix just forwards the $TZ to givsor environment only if it is set on host. Signed-off-by: Liu Yuan <[email protected]>
A little bit strange but okay, done :). |
EtiennePerot
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For e.g, with $TZ="Asia/Chongqing" on host
"TZ=" + time.tzname[0]
will set TZ=CST, which restult in utils such as 'date' output UTC time instead of CST time because "CST" isn't a valid timezone.
This fix just forwards the $TZ to givsor environment only if it is set on host.