-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ExtensionBaseUrl configurable. #39
Conversation
Hello, thanks for the PR! Are there any reasons that you need to use a GitHub mirror for downloading? I feel like this setting is a bit problematic and would confuse the users because the URL needs to be in a specific format. We also need to (prompt the user to) re-download the language server after applying the setting, or at least warn the user in the description that they would need to manually delete the current one to force a re-download. |
Because in China, github is not always accessible. |
BTW. I also made below changes:
So user can know it's downloading from new URL or not. |
Co-authored-by: thedemons <[email protected]>
Co-authored-by: thedemons <[email protected]>
Merged. Thank you! |
I am using a github mirror. So I want to make extensionBaseUrl configurable.