Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: inline messages #4399

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Fix: inline messages #4399

merged 1 commit into from
Aug 4, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 3, 2021

Details

Due to a recent upgrade to v6 of React-native-render-html. block styling change for the container element body which broke the inline messages.

Fixed Issues

$ Fixes #4377

Tests | QA Steps

  1. Open any conversation on NewDot.
  2. Send any message that contains inline formatted or unformatted text which should be a few words.
  3. If this case. This inline message should not extend to the full width of the viewport.
    e.g. Send this message.
`text`

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

issue-code-fix-m

iOS

Android

BEFORE AFTER
issue-code issue-code-fix

Note: Code formatting issue is #4005.

@parasharrajat parasharrajat requested a review from a team as a code owner August 3, 2021 22:33
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team August 3, 2021 22:33
@stitesExpensify stitesExpensify merged commit f772837 into Expensify:main Aug 4, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 4, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hold for payment 2021-08-17] Code blocks renders to the end of the edge of the window
3 participants