Clear stack before navigating to view transactions page. #55854

parasharrajat · 2025-01-28T12:49:21Z

Explanation of Change

Fixed Issues

$ #55707
PROPOSAL: #55707

Tests

Prerequisite:

Login in NewDot with an account which has a workspace.
Enable Expensify Card and Company Card from the Settings > workspaces > [Your workspace] > Workflows.
You have some assigned cards to your account from different workspaces and a assigned company card.

Expensify Card

Go to Expensify card in workspace menu on LHN.
Issue a new Expensify Card if not already.
Click on the card to view details.
Notice the View transactions button.
Click to navigate to the search page with transactions filtered to that card.

Company Card

Go to Company card in workspace menu on LHN.
Add a new Company Card if not already.
Click on the card to view details.
Notice the View transactions button.
Click to navigate to the search page with transactions filtered to that card.

Assigned Cards

Go to Settings > Wallet page.
Click on any assigned cards(Physical or virtual).
Check that it has a View Transactions button.
Click to navigate to the search page with transactions filtered to that card.
Click on any Assigned Company card.
Note that a popup opens with the view transactions button.
Click to navigate to the search page with transactions filtered to that card.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

28.01.2025_19.33.10_REC.mp4

Android: mWeb Chrome

28.01.2025_19.38.43_REC.mp4

iOS: Native

28.01.2025_19.20.07_REC.mp4

iOS: mWeb Safari

28.01.2025_19.21.44_REC.mp4

MacOS: Chrome / Safari

28.01.2025_18.43.01_REC.mp4

MacOS: Desktop

28.01.2025_19.18.33_REC.mp4

melvin-bot · 2025-01-28T12:49:27Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-01-28T14:42:46Z

@allgandalf Do we need to clear the filters as well?

allgandalf · 2025-01-29T06:58:34Z

@allgandalf Do we need to clear the filters as well?

I think so, @mountiny do we ?

mountiny · 2025-01-29T16:06:39Z

@parasharrajat when should we clear the filters?

parasharrajat · 2025-01-29T16:08:06Z

Before we open the view transactions page, should we clear the filters on search page?

mountiny · 2025-01-29T16:18:45Z

Before we open the view transactions page, should we clear the filters on search page?

You mean any other filters than cardID? I think yes, the only filter would be the cardID

allgandalf · 2025-01-30T06:53:53Z

@parasharrajat is this PR ready with the expected result? let me know when i can start testing

parasharrajat · 2025-01-30T09:38:12Z

src/libs/CardTransactionUtils.ts

+import Navigation from './Navigation/Navigation';
+import {buildCannedSearchQuery} from './SearchQueryUtils';
+
+function viewCardTransactions(cardID: string) {


Had to create a new file due to a cycling dependencies error.

…vigationclean

parasharrajat · 2025-01-30T09:43:50Z

@allgandalf This is ready for review.

allgandalf · 2025-01-30T13:25:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-01-30.at.6.54.49.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-30.at.6.57.30.PM.mov

allgandalf · 2025-01-30T13:34:25Z

Am i missing something, when i test this on iOS, i get directed to workspace initial options first :

Simulator.Screen.Recording.-.Expensify.testing.-.2025-01-30.at.19.03.47.mp4

parasharrajat · 2025-01-30T13:37:58Z

Ah, Shouldn't the dismissModal clear the stack in this case too? I will check.

parasharrajat · 2025-02-05T11:12:07Z

I was OOO. I will catch up soon with this one.

…vigationclean

parasharrajat · 2025-02-06T16:35:26Z

Trying to get access to my blocked account to test this.

…vigationclean

parasharrajat · 2025-02-13T16:32:32Z

@allgandalf I can't reproduce that issue after merging the main.

Clear stack before View transactions

025d7ce

parasharrajat requested a review from a team as a code owner January 28, 2025 12:49

melvin-bot bot requested review from allgandalf and removed request for a team January 28, 2025 12:49

mountiny assigned parasharrajat Jan 29, 2025

mountiny requested review from mountiny and removed request for mountiny January 29, 2025 16:06

Clear filters before navigating to card transactions page

a095098

parasharrajat commented Jan 30, 2025

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into parasharrajat/na…

12b83da

…vigationclean

Merge branch 'main' of github.com:Expensify/App into parasharrajat/na…

d870cb4

…vigationclean

Merge branch 'main' of github.com:Expensify/App into parasharrajat/na…

de4661e

…vigationclean

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clear stack before navigating to view transactions page. #55854

Clear stack before navigating to view transactions page. #55854

parasharrajat commented Jan 28, 2025 •

edited

Loading

melvin-bot bot commented Jan 28, 2025

parasharrajat commented Jan 28, 2025

allgandalf commented Jan 29, 2025

mountiny commented Jan 29, 2025

parasharrajat commented Jan 29, 2025

mountiny commented Jan 29, 2025

allgandalf commented Jan 30, 2025

parasharrajat Jan 30, 2025

parasharrajat commented Jan 30, 2025

allgandalf commented Jan 30, 2025 •

edited

Loading

allgandalf commented Jan 30, 2025

parasharrajat commented Jan 30, 2025

parasharrajat commented Feb 5, 2025 •

edited

Loading

parasharrajat commented Feb 6, 2025 •

edited

Loading

parasharrajat commented Feb 13, 2025

Clear stack before navigating to view transactions page. #55854

Are you sure you want to change the base?

Clear stack before navigating to view transactions page. #55854

Conversation

parasharrajat commented Jan 28, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Expensify Card

Company Card

Assigned Cards

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 28, 2025

parasharrajat commented Jan 28, 2025

allgandalf commented Jan 29, 2025

mountiny commented Jan 29, 2025

parasharrajat commented Jan 29, 2025

mountiny commented Jan 29, 2025

allgandalf commented Jan 30, 2025

parasharrajat Jan 30, 2025

Choose a reason for hiding this comment

parasharrajat commented Jan 30, 2025

allgandalf commented Jan 30, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf commented Jan 30, 2025

parasharrajat commented Jan 30, 2025

parasharrajat commented Feb 5, 2025 • edited Loading

parasharrajat commented Feb 6, 2025 • edited Loading

parasharrajat commented Feb 13, 2025

parasharrajat commented Jan 28, 2025 •

edited

Loading

allgandalf commented Jan 30, 2025 •

edited

Loading

parasharrajat commented Feb 5, 2025 •

edited

Loading

parasharrajat commented Feb 6, 2025 •

edited

Loading