-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static translations dropdown #56520
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hackathon sabotage
src/languages/en.ts
Outdated
es: { | ||
label: 'Spanish', | ||
}, | ||
en: 'English', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it make sense to show each language in it's own source? i.e: Español for Spanish, no matter what language you're currently in?
src/CONST.ts
Outdated
|
||
DEFAULT: 'en', | ||
}, | ||
|
||
LANGUAGES: ['en', 'es'], | ||
LANGUAGES: ['en', 'es', 'pt', 'it', 'ge', 'fr', 'cn', 'jp'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChatGPT says he's proficient with these other languages too
LANGUAGES: ['en', 'es', 'pt', 'it', 'ge', 'fr', 'cn', 'jp'], | |
LANGUAGES: ['en', 'es', 'pt', 'it', 'ge', 'fr', 'nl', 'pl', 'ru', 'tr', 'ko', 'cn', 'jp'], |
🚧 @dylanexpensify has triggered a test build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
@luacmartins drop down works w/no console errors 👍 |
Cmartins use translate live
🚧 @luacmartins has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
…or-selection Add Inter to unify fonts for languages page
🚧 @luacmartins has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
🚧 @luacmartins has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop