Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save logline at shutdown #1770

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Save logline at shutdown #1770

merged 2 commits into from
Jun 5, 2024

Conversation

tylerkaraszewski
Copy link
Contributor

Details

Adds a logline in /var/log/bedrock_shutdown when bedrock shuts down.

Format:

shutdown $PID $TIMESTAMP

Example:

shutdown 1685177 2024-06-05T22:51:02
shutdown 1686170 2024-06-05T22:54:15

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/171333

Tests

Build bedrock/auth in the VM.

run:

sudo service auth start
sudo service auth stop

inspect the contents of /var/log/bedrock_shutdown

Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@tylerkaraszewski tylerkaraszewski self-assigned this Jun 5, 2024
@justinpersaud justinpersaud merged commit b2adefe into main Jun 5, 2024
1 check passed
@justinpersaud justinpersaud deleted the tyler-shutdown-timestamp branch June 5, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpersaud justinpersaud justinpersaud approved these changes

Assignees

@tylerkaraszewski tylerkaraszewski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerkaraszewski @justinpersaud