Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 2 bottleneck logs to warns #1775

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Upgrade 2 bottleneck logs to warns #1775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BedrockServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2044,7 +2044,7 @@ void BedrockServer::_acceptSockets() {
uint64_t now = STimeNow();
if ((port != _controlPort) && (_outstandingSocketThreads >= _maxSocketThreads)) {
if ((lastLogged < now - 3'000'000)) {
SINFO("Not accepting any new socket threads as we already have " << _outstandingSocketThreads << " of " << _maxSocketThreads);
SWARN("Not accepting any new socket threads as we already have " << _outstandingSocketThreads << " of " << _maxSocketThreads);
lastLogged = now;
}
return;
Expand Down
4 changes: 2 additions & 2 deletions sqlitecluster/SQLitePool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ size_t SQLitePool::getIndex(bool createHandle) {
return index;
} else {
// Wait for a handle.
SINFO("Waiting for DB handle");
SWARN("Waiting for DB handle");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this one specifically be written in a loop while the server is receiving requests? not sure if that's a problem though, just noting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just as much of a problem when it's an info 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know; I meant, do we want to continue logging them all the time?

And what will happen if instead of thousands of lines with info we do thousands with warn?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what will happen if instead of thousands of lines with info we do thousands with warn?

I think we get a bugbot issue created but that's about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

_wait.wait(lock);
}
}
Expand Down Expand Up @@ -88,7 +88,7 @@ void SQLitePool::returnToPool(size_t index) {
}

SQLiteScopedHandle::SQLiteScopedHandle(SQLitePool& pool, size_t index) : _pool(pool), _index(index)
{}
{}

SQLiteScopedHandle::~SQLiteScopedHandle() {
_pool.returnToPool(_index);
Expand Down