Update SPerformanceTimer to log immediate

[marcaaron]

cc @coleaeason curious what you will say about these changes or if you have ideas on how else to do this. We appear to be using SPerformanceTimer in only one place. So, I decided to make it a general purpose / single use timer by default.

Details

Related to some logging I'd like to do in slow commands for fast-apis

Fixed Issues

Related to https://github.com/Expensify/Expensify/issues/393215

Tests

---

Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

[coleaeason]

Adding tyler for his thoughts on this vs something else

[tylerkaraszewski]

This seems to break the purpose of this class, as we no longer record the totals. Either that or it makes this into a fairly complex way to do a simpler job.

I am confused what the purpose of this change is. I'm guessing you want to use this class somewhere new, but for a simpler task.

It seems we could do that with a class that looks like:

class NewClass {
    chrono::steady_clock::time_point _lastStart = 0;
    void start() {
        _lastStart = 0;
    }
    void stop() {
        SINFO("Message about" << now - _lastStart);
    }
};

I wonder if we can collapse SAutoTimer and SPerformanceTimer into one thing, since they seem to do basically the same task, and then make a simpler timer class oif that's what we need.

[marcaaron]

Thanks. I don't have super strong feelings on this so let me know whatever you'd prefer. I am mainly looking for something to time some parts of the Auth code. I originally proposed to add a Bench class to Auth, but @coleaeason thought maybe we should use something that already exists.

[tylerkaraszewski]

Maybe add the Bench class in auth and create an issue to collapse these two Bedrock classes? It sounds like bench needs less functionality than we have here, and we can probably use only one of the two existing classes in bedrock.

[marcaaron]

Created an issue to look into consolidating the timers, but does not seem like a priority right now so closing this.