Test upgrades for HC-Tree #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerkaraszewski
commented
Jan 6, 2025
| @@ -195,7 +195,7 @@ ClusterTester<T>::~ClusterTester() | |||
| // Shut down everything but the leader first. | |||
| list<thread> threads; | |||
|
|
|||
| for (int i = 0; i< _size; i++) { | |||
| for (int i = 0; i < _size; i++) { | |||
There was a problem hiding this comment.
Just style here.
tylerkaraszewski
commented
Jan 6, 2025
| @@ -576,7 +576,7 @@ bool BedrockTester::readDB(const string& query, SQResult& result, bool online) | |||
| SData command("Query"); | |||
| command["Query"] = fixedQuery; | |||
| command["Format"] = "JSON"; | |||
| auto commandResult = executeWaitMultipleData({command}); | |||
| auto commandResult = executeWaitMultipleData({command}, 1); | |||
There was a problem hiding this comment.
This creates 10 connections by default and we only need one. Normally it works fine, but it's a waste of effort. IF we get into a state where the connections are failing, we fail 10 connections instead of 1 which is noisy.
tylerkaraszewski
commented
Jan 6, 2025
| } | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is added just so that we wan wait for either LEADING or FOLLOWING instead of just one or the other.
tylerkaraszewski
commented
Jan 6, 2025
| @@ -43,7 +43,7 @@ class BedrockTester { | |||
| string startServer(bool wait = true); | |||
|
|
|||
| // Stop a server by sending it a signal. | |||
| void stopServer(int signal = SIGTERM); | |||
| virtual void stopServer(int signal = SIGTERM); | |||
There was a problem hiding this comment.
This allows auth to override this to do extra checks.
cead22
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
https://github.com/Expensify/Expensify/issues/337537
Tests
Is tests.
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes