Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise only blockquotes followed by space #691

Merged

Conversation

robertKozik
Copy link
Contributor

image

This PR changes quote regex to enforce following space after >.
> not followed by space won't be parsed as quote. In the multiple level quote context spaces between > signs are irrelevent

Fixed Issues

$ Expensify/App#41696

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    I've Adjusted already present unit tests
  2. What tests did you perform that validates your changed worked?
    I've run unit tests and checked the changes in both example app of react-native-live-markdown and E/App itself, by bumping the expensify-common version to my branch head

QA

  1. What does QA need to do to validate your changes?
    bump expensify-common version in E/App and use chat normally - sent messages should be parsed with the new rule
  2. What areas to they need to test for regressions?
    All quotes usage are vulnerable to regressions

@robertKozik robertKozik requested a review from a team as a code owner May 7, 2024 10:41
@melvin-bot melvin-bot bot requested review from thienlnam and removed request for a team May 7, 2024 10:42
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good - could we also add tests for the negative case where the >hello doesn't turn into a blockquote?

@robertKozik
Copy link
Contributor Author

Sure, I'm on it 👀

Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@thienlnam thienlnam merged commit a018512 into Expensify:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants