home page view header & footer #13 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannanhassouna
requested changes
Oct 3, 2018
public/css/style.css
Outdated
| border-radius: 2px; | ||
| width: 200px; | ||
| position: relative; | ||
| width: 200px; |
There was a problem hiding this comment.
don't repeat yourself !! RULE !!
you user twice
width :200px;
public/css/style.css
Outdated
| flex-direction: column; | ||
| } | ||
|
|
||
| .contact-us p { |
There was a problem hiding this comment.
you can use
.contact-us:not(:last-child){
padding-bottom:10px;
margin-left: 10px;
}
that will be the same result of lines from (129 - 136)
| @@ -0,0 +1,188 @@ | |||
| *{ | |||
| margin: 0 auto; | |||
There was a problem hiding this comment.
you should make separate file to (header.css , footer.css)
because you separate them in partials
public/css/style.css
Outdated
|
|
||
| } | ||
|
|
||
| section { |
There was a problem hiding this comment.
why you put a general selector
| @@ -0,0 +1,188 @@ | |||
| *{ | |||
| margin: 0 auto; | |||
There was a problem hiding this comment.
please fix the indentation ..
| <div class="about-us"> | ||
| <h1>Marna House</h1> | ||
| <h2>Where Every Is Cool</h2> | ||
| <p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus</p> |
src/views/partials/header.hbs
Outdated
| <option value="Single">Single</option> | ||
| <option value="Double">Double</option> | ||
| <option value="Trible">Trible</option> | ||
| <option value="Mixed">Mixed</option> |
There was a problem hiding this comment.
we don't have option (Mixed).
| <span>check-out</span> | ||
| <label for="check-out"> | ||
| <input type="date" id="check-out" required></label> | ||
| <span>Type</span> |
There was a problem hiding this comment.
use label instead of span
src/views/layouts/main.hbs
Outdated
| <main> | ||
| {{{body}}} | ||
| </main> | ||
| {{>footer}} |
There was a problem hiding this comment.
surround
{{footer}}
with tag footer
src/views/layouts/main.hbs
Outdated
| {{>head}} | ||
| </head> | ||
| <body> | ||
| {{>header}} |
There was a problem hiding this comment.
surround
{{header}}
with tag header
kannanhassouna
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.