Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator options #396

Merged
merged 23 commits into from
Jun 1, 2024
Merged

Generator options #396

merged 23 commits into from
Jun 1, 2024

Conversation

BlackYps
Copy link
Collaborator

@BlackYps BlackYps commented May 18, 2024 •
edited
Loading

Remove the density parameters and instead allow choosing of the four generators to give better control over the kind of map you are generating without implying granular control like the density parameters did.

@BlackYps BlackYps requested a review from Sheikah45 May 20, 2024 17:27
Sheikah45
Sheikah45 requested changes May 21, 2024
View reviewed changes
Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note please don't use star imports. Most likely done by the IDE so just change that setting.

generator/src/main/java/com/faforever/neroxis/generator/PropGeneratorSupplier.java Outdated Show resolved Hide resolved
generator/src/main/java/com/faforever/neroxis/generator/ResourceGeneratorSupplier.java Outdated Show resolved Hide resolved
generator/src/main/java/com/faforever/neroxis/generator/TerrainGeneratorSupplier.java Outdated Show resolved Hide resolved
generator/src/main/java/com/faforever/neroxis/generator/TextureGeneratorSupplier.java Outdated Show resolved Hide resolved
generator/src/main/java/com/faforever/neroxis/generator/prop/BasicPropGenerator.java Show resolved Hide resolved
generator/src/main/java/com/faforever/neroxis/generator/style/CustomStyleGenerator.java Outdated Show resolved Hide resolved
generator/src/main/java/com/faforever/neroxis/generator/style/StyleGenerator.java Outdated Show resolved Hide resolved
generator/src/test/java/com/faforever/neroxis/generator/MapGeneratorParsingTest.java Outdated Show resolved Hide resolved
generator/src/main/java/com/faforever/neroxis/generator/MapGenerator.java Outdated Show resolved Hide resolved
shared/src/main/java/com/faforever/neroxis/map/SCMap.java Outdated Show resolved Hide resolved
@BlackYps
Copy link
Collaborator Author

I still need to add commands to output the new styles

@BlackYps BlackYps marked this pull request as draft May 27, 2024 12:11
@BlackYps BlackYps marked this pull request as ready for review May 27, 2024 22:36
@BlackYps BlackYps mentioned this pull request May 29, 2024
Merged
@Sheikah45 Sheikah45 mentioned this pull request May 29, 2024
Closed
@Sheikah45
Copy link
Member

This should allow unknown options to be backwards compatibility

@Sheikah45 Sheikah45 merged commit 9a301fa into develop Jun 1, 2024
1 check passed
@Sheikah45 Sheikah45 deleted the generator-options branch June 22, 2024 10:34
Gatsik added a commit to Gatsik/client that referenced this pull request Jul 14, 2024
@Gatsik
Make mew mapgen options work
9a34569 
see FAForever/Neroxis-Map-Generator#396
and FAForever/Neroxis-Map-Generator#401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikah45 Sheikah45 Sheikah45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlackYps @Sheikah45