Add a guard to prevent a buffer overflow when saving a game #6647
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4z0t
requested changes
Feb 7, 2025
lua/ui/globals/InternalSaveGame.lua
Outdated
| ---@param filename string | ||
| _G.InternalSaveGame = function(filename, friendlyFilename, onCompletionCallback) | ||
| if DebugAllocatedSize(filename) > 50 then | ||
| filename = filename:sub(0, 50) |
4z0t
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
According to @4z0t there's a possible buffer overflow in this function. This function is exposed to UI mods. It would technically allow a UI mod to run arbitrary code when the UI mod is enabled.
Checklist