feat(messaging): game join failed command

 * When player fails to join a game, instead of "notice", a new "game_join_failed" event is being sent, so the consumer can programmatically handle the exceptional behaviour

server/lobbyconnection.py

@@ -965,9 +965,10 @@ async def command_game_join(self, message):
             game = self.game_service[uuid]
         except KeyError:
             await self.send({
-                "command": "notice",
+                "command": "game_join_failed",
                 "style": "info",
-                "text": "The host has left the game."
+                "text": "The host has left the game.",
+                "uid": uuid
             })
             return
 
@@ -977,9 +978,10 @@ async def command_game_join(self, message):
         if not game or game.state is not GameState.LOBBY:
             self._logger.debug("Game not in lobby state: %s state %s", game, game.state)
             await self.send({
-                "command": "notice",
+                "command": "game_join_failed",
                 "style": "info",
-                "text": "The game you are trying to join is not ready."
+                "text": "The game you are trying to join is not ready.",
+                "uid": uuid
             })
             return
 
@@ -988,9 +990,10 @@ async def command_game_join(self, message):
 
         if game.password != password:
             await self.send({
-                "command": "notice",
+                "command": "game_join_failed",
                 "style": "info",
-                "text": "Bad password (it's case sensitive)."
+                "text": "Bad password (it's case sensitive).",
+                "uid": uuid
             })
             return
 

tests/unit_tests/test_lobbyconnection.py

@@ -416,9 +416,10 @@ async def test_command_game_join_without_password(
         **test_game_info
     })
     lobbyconnection.send.assert_called_once_with({
-        "command": "notice",
+        "command": "game_join_failed",
         "style": "info",
-        "text": "Bad password (it's case sensitive)."
+        "text": "Bad password (it's case sensitive).",
+        "uid": 42
     })
 
 
@@ -439,9 +440,10 @@ async def test_command_game_join_game_not_found(
         **test_game_info
     })
     lobbyconnection.send.assert_called_once_with({
-        "command": "notice",
+        "command": "game_join_failed",
         "style": "info",
-        "text": "The host has left the game."
+        "text": "The host has left the game.",
+        "uid": 42
     })
 
 
@@ -468,9 +470,10 @@ async def test_command_game_join_game_bad_init_mode(
         **test_game_info
     })
     lobbyconnection.send.assert_called_once_with({
-        "command": "notice",
+        "command": "game_join_failed",
         "style": "error",
-        "text": "The game cannot be joined in this way."
+        "text": "The game cannot be joined in this way.",
+        "uid": 42
     })