This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
SC-598 CHORE Disable unused html routes, XSS vuln averted #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omnikron
force-pushed
the
SC-598-disable-liftie-html-site
branch
from
f41f84d to
90646a5
Compare
omnikron
force-pushed
the
SC-598-disable-liftie-html-site
branch
from
90646a5 to
8bd2947
Compare
JMJustas
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://strava.atlassian.net/browse/SC-598
There was a potential (if unlikely) XSS vulnerability inherent in our rendering
of html that has come from outside sources.
There would probably be better ways to fix this, but since this service is slated for removal soon - have taken the machete approach and simply removed all html routes from the app, so that it now only serves JSON via
/api/<:resort>route – which AFAIK is the only one we need.