Improve the treatment of abstract, polymorphic functions that are used with array types #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d with array types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phase that is in charge of rewriting array-returning functions into outparam-style functions was a little bit over-zealous. Notably, in the case of a slice index operation, when the type of elements in an array already, MIR is already aware that such an operation will return a pointer, and there is no need to give is the whole "let's copy the result in an out-array" treatment.
This was the cause of a lot of pain on the Eurydice side, so fixing this properly here, with a note that this might be an instance of a more general pattern, which would avoid hardcoding something so specific.