optimize event deserialization

gossip/protocol.go

@@ -28,7 +28,7 @@ var ProtocolVersions = []uint{FTM62, FTM63}
 // protocolLengths are the number of implemented message corresponding to different protocol versions.
 var protocolLengths = map[uint]uint64{FTM62: EventsStreamResponse + 1, FTM63: EPsStreamResponse + 1}
 
-const protocolMaxMsgSize = 10 * 1024 * 1024 // Maximum cap on the size of a protocol message
+const protocolMaxMsgSize = inter.ProtocolMaxMsgSize // Maximum cap on the size of a protocol message
 
 // protocol message codes
 const (

inter/event_serializer.go

@@ -22,6 +22,8 @@ var (
 
 const MaxSerializationVersion = 1
 
+const ProtocolMaxMsgSize = 10 * 1024 * 1024
+
 func (e *Event) MarshalCSER(w *cser.Writer) error {
 	// version
 	if e.Version() > 0 {
@@ -116,6 +118,9 @@ func eventUnmarshalCSER(r *cser.Reader, e *MutableEventPayload) (err error) {
 	gasPowerLeft1 := r.U64()
 	// parents
 	parentsNum := r.U32()
+	if parentsNum > ProtocolMaxMsgSize/24 {
+		return cser.ErrTooLargeAlloc
+	}
 	parents := make(hash.Events, 0, parentsNum)
 	for i := uint32(0); i < parentsNum; i++ {
 		// lamport difference
@@ -150,7 +155,7 @@ func eventUnmarshalCSER(r *cser.Reader, e *MutableEventPayload) (err error) {
 		}
 	}
 	// extra
-	extra := r.SliceBytes()
+	extra := r.SliceBytes(ProtocolMaxMsgSize)
 
 	if version == 0 && epoch < 256 {
 		return ErrTooLowEpoch
@@ -205,6 +210,9 @@ func (bvs *LlrBlockVotes) UnmarshalCSER(r *cser.Reader) error {
 	start := r.U64()
 	epoch := r.U32()
 	num := r.U32()
+	if num > ProtocolMaxMsgSize/32 {
+		return cser.ErrTooLargeAlloc
+	}
 	records := make([]hash.Hash, num)
 	for i := range records {
 		r.FixedBytes(records[i][:])
@@ -300,6 +308,9 @@ func (e *MutableEventPayload) UnmarshalCSER(r *cser.Reader) error {
 			if size == 0 {
 				return cser.ErrNonCanonicalEncoding
 			}
+			if size > ProtocolMaxMsgSize/64 {
+				return cser.ErrTooLargeAlloc
+			}
 			for i := uint64(0); i < size; i++ {
 				tx, err := TransactionUnmarshalCSER(r)
 				if err != nil {
@@ -308,7 +319,7 @@ func (e *MutableEventPayload) UnmarshalCSER(r *cser.Reader) error {
 				txs = append(txs, tx)
 			}
 		} else {
-			b := r.SliceBytes()
+			b := r.SliceBytes(ProtocolMaxMsgSize)
 			err := rlp.DecodeBytes(b, &txs)
 			if err != nil {
 				return err
@@ -319,7 +330,7 @@ func (e *MutableEventPayload) UnmarshalCSER(r *cser.Reader) error {
 	// mps
 	mps := make([]MisbehaviourProof, 0)
 	if e.AnyMisbehaviourProofs() {
-		b := r.SliceBytes()
+		b := r.SliceBytes(ProtocolMaxMsgSize)
 		err := rlp.DecodeBytes(b, &mps)
 		if err != nil {
 			return err

inter/transaction_serializer.go

@@ -94,7 +94,7 @@ func TransactionUnmarshalCSER(r *cser.Reader) (*types.Transaction, error) {
 		r.FixedBytes(_to[:])
 		to = &_to
 	}
-	data := r.SliceBytes()
+	data := r.SliceBytes(ProtocolMaxMsgSize)
 	// sig
 	v := r.BigInt()
 	var sig [64]byte
@@ -116,10 +116,16 @@ func TransactionUnmarshalCSER(r *cser.Reader) (*types.Transaction, error) {
 	} else if txType == types.AccessListTxType || txType == types.DynamicFeeTxType {
 		chainID := r.BigInt()
 		accessListLen := r.U32()
+		if accessListLen > ProtocolMaxMsgSize/24 {
+			return nil, cser.ErrTooLargeAlloc
+		}
 		accessList := make(types.AccessList, accessListLen)
 		for i := range accessList {
 			r.FixedBytes(accessList[i].Address[:])
 			keysLen := r.U32()
+			if keysLen > ProtocolMaxMsgSize/32 {
+				return nil, cser.ErrTooLargeAlloc
+			}
 			accessList[i].StorageKeys = make([]common.Hash, keysLen)
 			for j := range accessList[i].StorageKeys {
 				r.FixedBytes(accessList[i].StorageKeys[j][:])

utils/cser/binary_test.go

@@ -226,7 +226,7 @@ func TestVals(t *testing.T) {
 				require.Equal(exp, got, i)
 			}
 			for i, exp := range expSliceBytes {
-				got := r.SliceBytes()
+				got := r.SliceBytes(255)
 				require.Equal(exp, got, i)
 			}
 			for i, exp := range expU8 {
@@ -314,7 +314,7 @@ func TestBadVals(t *testing.T) {
 				require.Equal(len(exp), len(got), i)
 			}
 			for i, exp := range expSliceBytes {
-				got := r.SliceBytes()
+				got := r.SliceBytes(1)
 				require.NotEqual(exp, got, i)
 				require.Equal(len(exp), len(got), i)
 			}

utils/cser/read_writer.go

@@ -11,8 +11,11 @@ import (
 var (
 	ErrNonCanonicalEncoding = errors.New("non canonical encoding")
 	ErrMalformedEncoding    = errors.New("malformed encoding")
+	ErrTooLargeAlloc        = errors.New("too large allocation")
 )
 
+const MaxAlloc = 100 * 1024
+
 type Writer struct {
 	BitsW  *bits.Writer
 	BytesW *fast.Writer
@@ -200,9 +203,12 @@ func (w *Writer) FixedBytes(v []byte) {
 	w.BytesW.Write(v)
 }
 
-func (r *Reader) SliceBytes() []byte {
+func (r *Reader) SliceBytes(maxLen int) []byte {
 	// read slice size
 	size := r.U56()
+	if size > uint64(maxLen) {
+		panic(ErrTooLargeAlloc)
+	}
 	buf := make([]byte, size)
 	// read slice content
 	r.FixedBytes(buf)
@@ -236,7 +242,7 @@ func (w *Writer) BigInt(v *big.Int) {
 
 func (r *Reader) BigInt() *big.Int {
 	// deserialize as an ordinary slice
-	buf := r.SliceBytes()
+	buf := r.SliceBytes(512)
 	if len(buf) == 0 {
 		return new(big.Int)
 	}