[ JSTEP-10 ] Migrate properties module tests to JUnit 5 (#526)

FasterXML · Jan 12, 2025 · 9359af8 · 9359af8
1 parent de01c68
commit 9359af8
Show file tree

Hide file tree

Showing 36 changed files with 220 additions and 86 deletions.
diff --git a/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsFactory.java b/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsFactory.java
@@ -2,13 +2,13 @@
 
 import java.io.*;
 import java.net.URL;
-import java.util.*;
+import java.util.Map;
+import java.util.Properties;
 
 import com.fasterxml.jackson.core.*;
 import com.fasterxml.jackson.core.format.InputAccessor;
 import com.fasterxml.jackson.core.format.MatchStrength;
 import com.fasterxml.jackson.core.io.IOContext;
-
 import com.fasterxml.jackson.dataformat.javaprop.impl.PropertiesBackedGenerator;
 import com.fasterxml.jackson.dataformat.javaprop.impl.WriterBackedGenerator;
 import com.fasterxml.jackson.dataformat.javaprop.io.Latin1Reader;

diff --git a/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsGenerator.java b/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsGenerator.java
@@ -1,6 +1,6 @@
 package com.fasterxml.jackson.dataformat.javaprop;
 
-import java.io.*;
+import java.io.IOException;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.util.Arrays;

diff --git a/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsMapper.java b/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsMapper.java
@@ -1,18 +1,12 @@
 package com.fasterxml.jackson.dataformat.javaprop;
 
 import java.io.IOException;
-import java.util.LinkedHashMap;
-import java.util.Map;
-import java.util.Properties;
+import java.util.*;
 
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.core.Version;
-import com.fasterxml.jackson.databind.DeserializationFeature;
-import com.fasterxml.jackson.databind.JavaType;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.cfg.CoercionAction;
-import com.fasterxml.jackson.databind.cfg.CoercionInputShape;
-import com.fasterxml.jackson.databind.cfg.MapperBuilder;
+import com.fasterxml.jackson.databind.*;
+import com.fasterxml.jackson.databind.cfg.*;
 
 public class JavaPropsMapper extends ObjectMapper
 {

diff --git a/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsParser.java b/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/JavaPropsParser.java
@@ -1,6 +1,7 @@
 package com.fasterxml.jackson.dataformat.javaprop;
 
-import java.io.*;
+import java.io.IOException;
+import java.io.Writer;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.util.Map;

diff --git a/...c/main/java/com/fasterxml/jackson/dataformat/javaprop/impl/PropertiesBackedGenerator.java b/...c/main/java/com/fasterxml/jackson/dataformat/javaprop/impl/PropertiesBackedGenerator.java
@@ -1,10 +1,10 @@
 package com.fasterxml.jackson.dataformat.javaprop.impl;
 
-import java.io.*;
+import java.io.IOException;
 import java.util.Map;
 import java.util.Properties;
 
-import com.fasterxml.jackson.core.*;
+import com.fasterxml.jackson.core.ObjectCodec;
 import com.fasterxml.jackson.core.io.IOContext;
 import com.fasterxml.jackson.dataformat.javaprop.JavaPropsGenerator;
 

diff --git a/...s/src/main/java/com/fasterxml/jackson/dataformat/javaprop/impl/WriterBackedGenerator.java b/...s/src/main/java/com/fasterxml/jackson/dataformat/javaprop/impl/WriterBackedGenerator.java
@@ -1,8 +1,9 @@
 package com.fasterxml.jackson.dataformat.javaprop.impl;
 
-import java.io.*;
+import java.io.IOException;
+import java.io.Writer;
 
-import com.fasterxml.jackson.core.*;
+import com.fasterxml.jackson.core.ObjectCodec;
 import com.fasterxml.jackson.core.io.IOContext;
 import com.fasterxml.jackson.dataformat.javaprop.JavaPropsGenerator;
 import com.fasterxml.jackson.dataformat.javaprop.io.JPropEscapes;

diff --git a/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/io/JPropReadContext.java b/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/io/JPropReadContext.java
@@ -1,8 +1,10 @@
 package com.fasterxml.jackson.dataformat.javaprop.io;
 
-import java.util.*;
+import java.util.Iterator;
+import java.util.Map;
 
-import com.fasterxml.jackson.core.*;
+import com.fasterxml.jackson.core.JsonStreamContext;
+import com.fasterxml.jackson.core.JsonToken;
 import com.fasterxml.jackson.dataformat.javaprop.util.JPropNode;
 
 /**

diff --git a/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/io/JPropWriteContext.java b/properties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/io/JPropWriteContext.java
@@ -1,6 +1,7 @@
 package com.fasterxml.jackson.dataformat.javaprop.io;
 
-import com.fasterxml.jackson.core.*;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.JsonStreamContext;
 //import com.fasterxml.jackson.core.json.JsonWriteContext;
 
 public class JPropWriteContext

diff --git a/...erties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/util/JPropNodeBuilder.java b/...erties/src/main/java/com/fasterxml/jackson/dataformat/javaprop/util/JPropNodeBuilder.java
@@ -3,7 +3,7 @@
 import java.util.Map;
 import java.util.Properties;
 
-import com.fasterxml.jackson.dataformat.javaprop.*;
+import com.fasterxml.jackson.dataformat.javaprop.JavaPropsSchema;
 
 public class JPropNodeBuilder
 {

diff --git a/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/ArrayGenerationTest.java b/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/ArrayGenerationTest.java
@@ -3,12 +3,17 @@
 import java.util.Map;
 import java.util.Properties;
 
+import org.junit.jupiter.api.Test;
+
 import com.fasterxml.jackson.dataformat.javaprop.util.Markers;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
 public class ArrayGenerationTest extends ModuleTestBase
 {
     private final JavaPropsMapper MAPPER = newPropertiesMapper();
 
+    @Test
     public void testPointListSimple() throws Exception
     {
         Points input = new Points
@@ -35,6 +40,7 @@ public void testPointListSimple() throws Exception
         }
     }
 
+    @Test
     public void testPointListWithIndex() throws Exception
     {
         JavaPropsSchema schema = JavaPropsSchema.emptySchema()
@@ -65,6 +71,7 @@ public void testPointListWithIndex() throws Exception
         }
     }
 
+    @Test
     public void testPointListWithCustomMarkers() throws Exception
     {
         JavaPropsSchema schema = JavaPropsSchema.emptySchema()

diff --git a/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/ArrayParsingTest.java b/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/ArrayParsingTest.java
@@ -4,12 +4,14 @@
 import java.util.List;
 import java.util.Map;
 
-import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonProperty;
-import com.fasterxml.jackson.annotation.JsonValue;
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.annotation.*;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectReader;
 
+import static org.junit.jupiter.api.Assertions.*;
+
 public class ArrayParsingTest extends ModuleTestBase
 {
     static class ZKConfig {
@@ -57,6 +59,7 @@ static class StringArrayWrapper {
 
     private final ObjectMapper MAPPER = newPropertiesMapper();
 
+    @Test
     public void testArrayWithBranch() throws Exception
     {
         // basically "extra" branch should become as first element, and
@@ -92,6 +95,7 @@ public void testArrayWithBranch() throws Exception
         assertTrue(ob instanceof Map);
     }
 
+    @Test
     public void testPointList() throws Exception
     {
         _testPointList(false, false);
@@ -129,6 +133,7 @@ private void _testPointList(boolean useBytes, boolean allowIndex) throws Excepti
         assertEquals(6, result.p.get(2).y);
     }
 
+    @Test
     public void testPointListWithIndex() throws Exception
     {
         _testPointListWithIndex(false);
@@ -153,6 +158,7 @@ private void _testPointListWithIndex(boolean useBytes) throws Exception
         assertEquals(4, result.p.get(1).y);
     }
 
+    @Test
     public void testZKPojo() throws Exception
     {
         _testZKPojo(false, false);

diff --git a/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/BinaryParsingTest.java b/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/BinaryParsingTest.java
@@ -1,11 +1,13 @@
 package com.fasterxml.jackson.dataformat.javaprop;
 
-import static org.junit.Assert.assertArrayEquals;
-
 import java.nio.ByteBuffer;
 import java.util.Map;
 import java.util.Properties;
 
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
 public class BinaryParsingTest extends ModuleTestBase
 {
     // [dataformats-text#74]: problem with multiple binary fields
@@ -31,6 +33,7 @@ public MyBean(boolean bogus) {
     private final JavaPropsMapper MAPPER = newPropertiesMapper();
 
     // [dataformats-text#74]
+    @Test
     public void testMultipleBinaryFields() throws Exception
     {
         final MyBean src = new MyBean(true);

diff --git a/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/CustomSeparatorsTest.java b/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/CustomSeparatorsTest.java
@@ -1,11 +1,16 @@
 package com.fasterxml.jackson.dataformat.javaprop;
 
+import org.junit.jupiter.api.Test;
+
 import com.fasterxml.jackson.databind.ObjectMapper;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
 public class CustomSeparatorsTest extends ModuleTestBase
 {
     private final ObjectMapper MAPPER = newPropertiesMapper();
 
+    @Test
     public void testCustomPathSeparator() throws Exception
     {
         JavaPropsSchema schema = JavaPropsSchema.emptySchema()

diff --git a/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/DefaultConfigsTest.java b/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/DefaultConfigsTest.java
@@ -2,15 +2,17 @@
 
 import java.io.StringWriter;
 
-import com.fasterxml.jackson.core.JsonGenerator;
-import com.fasterxml.jackson.core.JsonParser;
-import com.fasterxml.jackson.core.Version;
-import com.fasterxml.jackson.core.Versioned;
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.core.*;
+
+import static org.junit.jupiter.api.Assertions.*;
 
 public class DefaultConfigsTest extends ModuleTestBase
 {
     private final String ARTIFACT_ID = "jackson-dataformat-properties";
 
+    @Test
     public void testMapperBaseConfig()
     {
         JavaPropsMapper mapper = newPropertiesMapper();
@@ -19,6 +21,7 @@ public void testMapperBaseConfig()
         assertNotSame(mapper, copy);
     }
 
+    @Test
     public void testFactoryBaseConfig()
     {
         JavaPropsFactory f = JavaPropsFactory.builder().build();
@@ -32,6 +35,7 @@ public void testFactoryBaseConfig()
         assertFalse(f.canUseCharArrays());
     }
 
+    @Test
     public void testGeneratorConfig() throws Exception
     {
         JavaPropsFactory f = JavaPropsFactory.builder().build();
@@ -49,6 +53,7 @@ public void testGeneratorConfig() throws Exception
         gen.close();
     }
 
+    @Test
     public void testParserConfig() throws Exception
     {
         JavaPropsFactory f = new JavaPropsFactory();

diff --git a/...rties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/GenerationEscapingTest.java b/...rties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/GenerationEscapingTest.java
@@ -1,13 +1,19 @@
 package com.fasterxml.jackson.dataformat.javaprop;
 
-import java.util.*;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.junit.jupiter.api.Test;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
 public class GenerationEscapingTest extends ModuleTestBase
 {
     private final ObjectMapper MAPPER = newPropertiesMapper();
 
+    @Test
     public void testKeyEscaping() throws Exception
     {
         Map<String,String> input = new HashMap<>();
@@ -23,6 +29,7 @@ public void testKeyEscaping() throws Exception
         assertEquals("combo\\tkey=value\n", MAPPER.writeValueAsString(input));
     }
 
+    @Test
     public void testValueEscaping() throws Exception
     {
         /*

diff --git a/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/MapParsingTest.java b/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/MapParsingTest.java
@@ -2,8 +2,14 @@
 
 import java.util.Map;
 
+import org.junit.jupiter.api.Test;
+
 import com.fasterxml.jackson.databind.ObjectMapper;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+
 public class MapParsingTest extends ModuleTestBase
 {
     static class MapWrapper {
@@ -17,6 +23,7 @@ static class MapWrapper {
     /**********************************************************************
      */
 
+    @Test
     public void testMapWithBranchNoEscaping() throws Exception
     {
         ObjectMapper mapper = newPropertiesMapper();
@@ -37,6 +44,7 @@ public void testMapWithBranchNoEscaping() throws Exception
         assertEquals("fourth", ((Map<?,?>) w.map.get("ab\\")).get("c"));
     }
 
+    @Test
     public void testMapWithBranchBackslashEscape() throws Exception
     {
         JavaPropsMapper mapper = newPropertiesMapper();
@@ -75,6 +83,7 @@ public void testMapWithBranchBackslashEscape() throws Exception
         assertEquals("twelfth", ((Map<?,?>) w.map.get("xy\\.d")).get("ij"));
     }
 
+    @Test
     public void testMapWithBranchHashEscape() throws Exception
     {
         JavaPropsMapper mapper = newPropertiesMapper();

diff --git a/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/ModuleTestBase.java b/properties/src/test/java/com/fasterxml/jackson/dataformat/javaprop/ModuleTestBase.java
@@ -1,19 +1,20 @@
 package com.fasterxml.jackson.dataformat.javaprop;
 
-import java.io.ByteArrayInputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.StringReader;
+import java.io.*;
 import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 import java.util.List;
 
-import com.fasterxml.jackson.core.*;
+import com.fasterxml.jackson.annotation.JsonPropertyOrder;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.JsonToken;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectReader;
-import com.fasterxml.jackson.annotation.JsonPropertyOrder;
 
-public abstract class ModuleTestBase extends junit.framework.TestCase
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
+
+public abstract class ModuleTestBase
 {
     @JsonPropertyOrder({ "topLeft", "bottomRight" })
     protected static class Rectangle {