Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ JSTEP-10 ] Migrate csv module tests to JUnit 5 #525

Merged
merged 13 commits into from
Jan 12, 2025

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Jan 11, 2025

related to #523

Blocked by #524

@JooHyukKim JooHyukKim marked this pull request as draft January 11, 2025 08:38
@JooHyukKim JooHyukKim changed the title [ JSTEP-10 ] Migrate csv modules to JUnit 5 [ JSTEP-10 ] Migrate csv module tests to JUnit 5 Jan 11, 2025
@JooHyukKim JooHyukKim marked this pull request as ready for review January 12, 2025 01:25
Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, last piece to merge for this repo!

@cowtowncoder cowtowncoder merged commit c702930 into FasterXML:2.19 Jan 12, 2025
4 checks passed
@cowtowncoder
Copy link
Member

Finally merged all the way to master.

@JooHyukKim I think you can next proceed to "failing" -> "tofix" changes for this repo and then we're done?

@cowtowncoder
Copy link
Member

Quick note: I also removed JUnit 4 dependency from main pom.xml of master.

@JooHyukKim JooHyukKim deleted the joohyukkim/2.19/523-csv-tests branch January 13, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants