Skip to content

Commit

Permalink
[refactor] Update backend service URL handling
Browse files Browse the repository at this point in the history
  • Loading branch information
charlieyl committed Jan 15, 2025
1 parent 41e04c7 commit 52ce93f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions python/fedml/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,9 @@ def _get_backend_service():

if lp and lpp:
# if lp and lpp is set, prioritize using them as the backend service url.
if lpp == 80:
if str(lpp) == "80":
return f"http://{lp}"
elif lpp == 443:
elif str(lpp) == "443":
return f"https://{lp}"
else:
return f"http://{lp}:{lpp}"
Expand Down
3 changes: 1 addition & 2 deletions python/fedml/core/mlops/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import fedml
from fedml import constants
from fedml.computing.scheduler.comm_utils import sys_utils
from fedml.computing.scheduler.slave.base_slave_protocol_manager import FedMLBaseSlaveProtocolManager
from fedml.core.mlops.mlops_configs import MLOpsConfigs
from .mlops_constants import MLOpsConstants

Expand Down Expand Up @@ -1254,7 +1253,7 @@ def bind_simulation_device(args, userid):
else:
setattr(args, "log_file_dir", ClientConstants.get_log_file_dir())
setattr(args, "device_id", FedMLAccountManager.get_device_id())
runner = FedMLBaseSlaveProtocolManager(args)
runner = FedMLSlaveProtocolManager(args)
setattr(args, "config_version", version)
setattr(args, "cloud_region", "")

Expand Down

0 comments on commit 52ce93f

Please sign in to comment.