-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add param names to jsdocs, remove types separation #124
base: main
Are you sure you want to change the base?
Conversation
"description": "A JavaScript package to calculate thermophysiological, thermal comfort, thermal stress indices", | ||
"type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed for ES6 modules (importing modules with the modern syntax import ... from
. Are we sure we want to revert to CommonJS (commonJS is not supported in browsers and is generally considered that new projects should use ES6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me verify is it still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szaldivar yes, we still need it to use with import {} from...
.
What did you run into when using the library? |
We are using it for node backend with nestjs. |
Thank you @szaldivar for commenting and reviewing the Pull request. I will leave it with you since you have a deeper understanding of the topic. |
Hey,
while we tried to use this library discovered that there are small issues with type declarations:
PR fixes both issues.