Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new scrolling #14

Merged
merged 4 commits into from
May 9, 2019
Merged

Update new scrolling #14

merged 4 commits into from
May 9, 2019

Conversation

Xanfre
Copy link
Contributor

@Xanfre Xanfre commented May 8, 2019

This includes a small change in how scrolling is detected to improve its behavior in extreme circumstances. It is not terribly important, but may be preferable for select users.
Following this, I think I will be able to leave that cursed text box alone.

@FenPhoenix
Copy link
Owner

To be clear, the fix is in the WParam stuff, right?
If so, I'll accept it but I'll remove the following code if you don't mind

case InteropMisc.WM_MBUTTONDOWN:
break;
case InteropMisc.WM_MBUTTONDBLCLK:
break;

as it prevents autoscroll which some people may want.

@Xanfre
Copy link
Contributor Author

Xanfre commented May 9, 2019

Yes, it just modifies the WParam values required to trigger the scroll events. On most machines, it likely will make no difference, but this is a more compatible implementation.

I removed the mentioned code, as it is true that some may find autoscrolling useful. Perhaps I should look into what is causing the cursor flickering exclusively in that function, as it is puzzling that it remains while all other forms of flickering in the readme box no longer occur.

@FenPhoenix
Copy link
Owner

If you find a solution for the autoscroll cursor flicker, I'd be happy to take a look at it. Meantime, accepting this pull request.

@FenPhoenix FenPhoenix merged commit 9441599 into FenPhoenix:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants