TASK: PhpStan level 5

Flowpack · Dec 28, 2024 · 4dda134 · 4dda134
1 parent aea163d
commit 4dda134
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/Classes/Aspects/ContentCacheAspect.php b/Classes/Aspects/ContentCacheAspect.php
@@ -15,13 +15,6 @@ class ContentCacheAspect
 {
     private $hadUncachedSegments = false;
 
-    private $cacheTags = [];
-
-    /**
-     * @var null|int
-     */
-    private $shortestLifetime = null;
-
     /**
      * @Flow\Inject
      * @var StringFrontend

diff --git a/Classes/Middleware/RequestCacheMiddleware.php b/Classes/Middleware/RequestCacheMiddleware.php
@@ -54,7 +54,7 @@ class RequestCacheMiddleware implements MiddlewareInterface
     protected $ignoredCookieParams;
 
     /**
-     * @var boolean
+     * @var int
      * @Flow\InjectConfiguration(path="maxPublicCacheTime")
      */
     protected $maxPublicCacheTime;
@@ -75,7 +75,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
             $age = time() - $cacheEntry['timestamp'];
             $response = Message::parseResponse($cacheEntry['response']);
             return $response
-                ->withHeader('Age', $age)
+                ->withHeader('Age', (string)$age)
                 ->withHeader(self::HEADER_INFO, 'HIT: ' . $entryIdentifier);
         }
 

diff --git a/composer.json b/composer.json
@@ -26,6 +26,7 @@
         "test:style": "phpcs --colors -n --standard=PSR12 Classes",
         "test:stan": "phpstan analyse Classes",
         "cc": "phpstan clear cache",
+        "fix": ["composer fix:style"],
         "test": ["composer test:style" , "composer test:stan"]
     },
     "config": {

diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,5 @@
+parameters:
+	level: 5
+	paths:
+		- Classes
+	reportUnmatchedIgnoredErrors: false