Switched to PSR-15 middleware for Neos 7.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
reviewed
Jan 8, 2021
bwaidelich
reviewed
Jan 8, 2021
|
@bwaidelich Thank you for your feedback! Just renamed it. |
bwaidelich
reviewed
Jan 8, 2021
|
The file has also been renamed. What still needs to be rewritten are the tests. I have not yet updated them. |
bwaidelich
reviewed
Jan 12, 2021
|
|
||
| /** | ||
| * Test case for the BackendUriDimensionPresetDetector | ||
| */ | ||
| class DetectContentSubgraphComponentTest extends FunctionalTestCase | ||
| class DetectContentSubgraphMiddlewareTest extends FunctionalTestCase |
There was a problem hiding this comment.
File needs to be renamed accordingly
bwaidelich
reviewed
Jan 12, 2021
Tests/Unit/Http/ContentDimensionLinking/DimensionPresetLinkProcessorResolverTest.php
Show resolved
Hide resolved
ah right. It's just the test file that hasn't been renamed it seems |
|
I updated to 7.0 and it broke neos-dimensionresolver. Found this PR. Is this PR ready for merging? :) |
|
just checked if everything is renamed and it should be save to merge. |
|
Any updates on this? @bwaidelich |
bwaidelich
approved these changes
Mar 30, 2021
albe
approved these changes
Mar 30, 2021
|
Let's merge 🤞 |
|
Could you please tag this commit, so composer will install it without whining about minimum stability requirements :D ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updated my fork to Neos 7.0 (the one with the resolutionHost feature #3) - It may be helpful to apply the changes here as well.