Upgrade Multimedia package base on 6.6.52 #2055

zelan-nxp · 2025-01-07T09:32:11Z

Upstream MM packages:

dsp: 2.1.8 -> 2.1.9
opencl-converter: 0.5.0 ->0.6.0
imx-parser: 4.9.1- >4.9.2
alsa-lib: upstream patch.
imx-vpuwrapper: drop unneeded patch

recipes-multimedia/alsa/alsa-lib_%.bbappend

otavio · 2025-01-07T14:19:36Z

I would like to clarify a comment I made earlier. It would be beneficial to improve the comments in each commit log. Specifically, I suggest describing the individual changes made to each recipe within their respective commit logs. This detailed documentation will be useful for referencing the reasons behind each change in the future.

recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb

thochstein · 2025-01-08T16:06:10Z

recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb

-# it uses nested functions sadly, in ext/wayland/gstwaylandsink.c for GST_ELEMENT_REGISTER_DEFINE
-#
-TOOLCHAIN = "gcc"
+


Not sure whether this can be removed. It appears that we have been building without this change all along, which makes me think that we do not build whatever causes the problem. It might be better to not upstream this and instead to align meta-imx with this change.

This is likely to avoid using other toolchain in case it is chosen as default. For example, it is likely to fix a problem if the distribution uses CLang as default toolchain.

Ah, right, so bottom line this is backwards again. @zelan-nxp, please remove this change here and instead add the lines to meta-imx.

@zelan-nxp, I tried to clarify my comment. We need to take these lines into meta-imx, not remove them from meta-freescale.

@otavio, this item is marked resolved but is not. Can you Unresolve it?

recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.24.7.imx.bb

recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.24.7.imx.bb

thochstein · 2025-01-08T16:42:19Z

recipes-multimedia/gstreamer/gstreamer1.0_1.24.7.imx.bb

-           file://0003-tests-use-a-dictionaries-for-environment.patch \
-           file://0004-tests-add-helper-script-to-run-the-installed_tests.patch \
+           file://0003-tests-use-a-dictionaries-for-environment.patch;striplevel=3 \
+           file://0004-tests-add-helper-script-to-run-the-installed_tests.patch;striplevel=3 \


This change was dropped upstream.

@zelan-nxp, please check that our recipes in meta-imx are aligned with the latest for the next release.

Yes, I check the next release ,It was droppd. Just align with meta-imx, It's ok as we have override them like this:

# Use i.MX fork of GST for customizations SRC_URI:remove = "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-${PV}.tar.xz \ file://0001-tests-respect-the-idententaion-used-in-meson.patch \ file://0002-tests-add-support-for-install-the-tests.patch \ file://0003-tests-use-a-dictionaries-for-environment.patch;striplevel=3 \ file://0004-tests-add-helper-script-to-run-the-installed_tests.patch;striplevel=3 \ "

I really didn't understand what you meant. Do you mean that all those patches are not applied in your new version?

You can drop them from your upcoming recipe; however, I don't understand why you are dropping them. Considering that you are basing it on a specific recipe version, you should keep it as close as possible to the copy that you are doing.

What's happening here is a previous upstreaming did change these lines so they no longer match the copied recipe (from OE-Core/poky). So, @zelan-nxp's change here is re-aligning the copied recipe.

@zelan-nxp, we need keep our copied recipe in meta-imx up to date. The recipe in OE-Core removed ;striplevel=3 from these lines some time ago: openembedded/openembedded-core@d0a546e.

@zelan-nxp see @thochstein comment.

It may be okay to take this change. It does make the copied recipe actually match the checksum it claims to be copied from. Unless there was some reason why we need to remove the change. @hiagofranco, do you remember why you removed ;striplevel=3?

recipes-multimedia/imx-codec/imx-codec_4.9.0.bb

otavio · 2025-01-09T11:36:53Z

recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.24.7.imx.bb

    file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe \
 "
 # Enable pulsesink in gstreamer
-PACKAGECONFIG:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}"
+PACKAGECONFIG:append = " pulseaudio"


This is a wrong change because that would cause this feature to be enabled independently if it is supported by the distribution or not.

Suggested change

PACKAGECONFIG:append = " pulseaudio"

PACKAGECONFIG:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', ' pulseaudio', '', d)}"

recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb

recipes-multimedia/gstreamer/imx-gst1.0-plugin_git.bb

otavio · 2025-01-13T20:15:02Z

Please rebase this pull request because I made the change to remove the checksum across all the files to a single commit. So you will need also to remove this from this and other pull requests.

Override arm32 build time flag Signed-off-by: Zelan Zou <[email protected]>

Signed-off-by: Zelan Zou <[email protected]>

otavio · 2025-01-14T11:08:43Z

recipes-multimedia/imx-dsp/imx-dsp_2.1.9.bb


-inherit fsl-eula-unpack autotools pkgconfig
+inherit fsl-eula-recent autotools pkgconfig fsl-eula2-unpack2


@zelan-nxp, please don't upstream fsl-eula-recent and fsl-eula2 usage. Update the recipe without these classes. I need to work on it before upstreaming.

quaresmajose · 2025-01-14T16:37:19Z

recipes-multimedia/gstreamer/gstreamer1.0_1.24.7.imx.bb


 S = "${WORKDIR}/git"

+PACKAGECONFIG[tests] = "-Dtests=enabled,-Dtests=disabled"


If the extra patchset for tests is been removed we should also explicitly disable the tests because they won't work.

PACKAGECONFIG[tests] = "" EXTRA_OEMESON += "-Dtests=disabled"

Bump version 2.1.8 -> 2.1.9 Signed-off-by: Zelan Zou <[email protected]>

Bump version 0.5.0 -> 0.6.0 Signed-off-by: Zelan Zou <[email protected]>

Bump version 4.9.1 -> 4.9.2 Signed-off-by: Zelan Zou <[email protected]>

Signed-off-by: Zelan Zou <[email protected]>

otavio approved these changes Jan 7, 2025

View reviewed changes

recipes-multimedia/alsa/alsa-lib_%.bbappend Outdated Show resolved Hide resolved

otavio mentioned this pull request Jan 7, 2025

Upgrade BSP to LF6.6.52_2.2.0 #2048

Open

18 tasks

zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 876ea2c to bf8e076 Compare January 8, 2025 09:49

thochstein reviewed Jan 8, 2025

View reviewed changes

recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb Outdated Show resolved Hide resolved

thochstein reviewed Jan 8, 2025

View reviewed changes

recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.24.7.imx.bb Outdated Show resolved Hide resolved

thochstein reviewed Jan 8, 2025

View reviewed changes

recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.24.7.imx.bb Outdated Show resolved Hide resolved

thochstein reviewed Jan 8, 2025

View reviewed changes

recipes-multimedia/imx-codec/imx-codec_4.9.0.bb Outdated Show resolved Hide resolved

zelan-nxp force-pushed the multimedia-package-6.6.52 branch 2 times, most recently from 2049471 to 671393d Compare January 9, 2025 11:11

otavio reviewed Jan 9, 2025

View reviewed changes

recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb Outdated Show resolved Hide resolved

otavio reviewed Jan 9, 2025

View reviewed changes

recipes-multimedia/gstreamer/imx-gst1.0-plugin_git.bb Outdated Show resolved Hide resolved

zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 671393d to 73aec8c Compare January 9, 2025 12:39

otavio self-requested a review January 13, 2025 20:14

zelan-nxp added 2 commits January 14, 2025 03:09

alsa-lib: Update to L6.6.52-2.2.0 release

e9e950f

Override arm32 build time flag Signed-off-by: Zelan Zou <[email protected]>

imx-alsa-plugins_git: Switch to L6.6.52-2.2.0 release branch

d76122c

Signed-off-by: Zelan Zou <[email protected]>

zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 73aec8c to b45e4fc Compare January 14, 2025 02:17

otavio reviewed Jan 14, 2025

View reviewed changes

otavio requested review from otavio and thochstein January 14, 2025 11:09

otavio added the backport scarthgap label Jan 14, 2025

quaresmajose reviewed Jan 14, 2025

View reviewed changes

zelan-nxp force-pushed the multimedia-package-6.6.52 branch from b45e4fc to 44d3478 Compare January 15, 2025 11:29

zelan-nxp added 3 commits January 15, 2025 12:33

imx-dsp: Update to L6.6.52_2.2.0 release

b285aac

Bump version 2.1.8 -> 2.1.9 Signed-off-by: Zelan Zou <[email protected]>

imx-opencl-converter: Update to L6.6.52_2.2.0 release

ec9730b

Bump version 0.5.0 -> 0.6.0 Signed-off-by: Zelan Zou <[email protected]>

imx-parser: Update to L6.6.52_2.2.0 release

7404455

Bump version 4.9.1 -> 4.9.2 Signed-off-by: Zelan Zou <[email protected]>

imx-vpuwrap: Update to L6.6.52_2.2.0 release

ee407ee

Signed-off-by: Zelan Zou <[email protected]>

zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 44d3478 to ee407ee Compare January 15, 2025 11:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Multimedia package base on 6.6.52 #2055

Upgrade Multimedia package base on 6.6.52 #2055

zelan-nxp commented Jan 7, 2025 •

edited

Loading

otavio commented Jan 7, 2025

thochstein Jan 8, 2025 •

edited

Loading

otavio Jan 8, 2025

thochstein Jan 8, 2025 •

edited

Loading

thochstein Jan 14, 2025

thochstein Jan 14, 2025

thochstein Jan 8, 2025

zelan-nxp Jan 9, 2025 •

edited

Loading

otavio Jan 9, 2025

thochstein Jan 9, 2025

otavio Jan 14, 2025

thochstein Jan 14, 2025

otavio Jan 9, 2025

otavio Jan 14, 2025 •

edited

Loading

otavio commented Jan 13, 2025

otavio Jan 14, 2025

thochstein Jan 14, 2025

quaresmajose Jan 14, 2025

	PACKAGECONFIG:append = " pulseaudio"
	PACKAGECONFIG:append = "${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', ' pulseaudio', '', d)}"


		inherit fsl-eula-unpack autotools pkgconfig
		inherit fsl-eula-recent autotools pkgconfig fsl-eula2-unpack2


		S = "${WORKDIR}/git"

		PACKAGECONFIG[tests] = "-Dtests=enabled,-Dtests=disabled"

Upgrade Multimedia package base on 6.6.52 #2055

Are you sure you want to change the base?

Upgrade Multimedia package base on 6.6.52 #2055

Conversation

zelan-nxp commented Jan 7, 2025 • edited Loading

otavio commented Jan 7, 2025

thochstein Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thochstein Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zelan-nxp Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

otavio Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

otavio commented Jan 13, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zelan-nxp commented Jan 7, 2025 •

edited

Loading

thochstein Jan 8, 2025 •

edited

Loading

thochstein Jan 8, 2025 •

edited

Loading

zelan-nxp Jan 9, 2025 •

edited

Loading

otavio Jan 14, 2025 •

edited

Loading