Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcore-demos: Upgrade to 6.6.52_2.2.0 #2056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mcore-demos: Upgrade to 6.6.52_2.2.0 #2056

wants to merge 1 commit into from

Conversation

zelan-nxp
Copy link
Contributor

@zelan-nxp zelan-nxp commented Jan 7, 2025 •
edited
Loading

imx95 mocre: 2.16.001 -> 24.12.00
Install elf binary to /usr/lib/firmware/

otavio
otavio requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but please improve the commit log.

@otavio otavio mentioned this pull request Jan 7, 2025
Closed
18 tasks
@zelan-nxp zelan-nxp force-pushed the mcore-L6.6.52 branch 2 times, most recently from 205ae8d to b1cdd3d Compare January 9, 2025 03:14
otavio
otavio reviewed Jan 13, 2025
View reviewed changes
recipes-fsl/mcore-demos/imx-mcore-demos.inc Outdated
Comment on lines 60 to 63

FILES:${PN} = "${nonarch_base_libdir}/firmware"

INSANE_SKIP:${PN} = "arch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How has this recipe been tested? removing those files caused an error during the build, did you really check that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change need to upstream fsl-eula2-unpack2.bbclasee. I removed this change.

@otavio
Copy link
Member

otavio commented Jan 13, 2025

Please rebase this pull request because I made the change to remove the checksum across all the files to a single commit. So you will need also to remove this from this and other pull requests.

@otavio otavio requested a review from thochstein January 14, 2025 11:01
thochstein
thochstein approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@thochstein thochstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine, but it does seem odd that the 1.0.1 recipe doesn't use the .inc file.

@zelan-nxp zelan-nxp force-pushed the mcore-L6.6.52 branch 2 times, most recently from 1882c08 to 540f161 Compare January 15, 2025 06:37
@zelan-nxp
Copy link
Contributor Author

Changes are fine, but it does seem odd that the 1.0.1 recipe doesn't use the .inc file.
Good catch. imx7d m4 demos binary name is imx7d-sabresd-m4-freertos-1.0.1.bin, no elf in package, Which special case than others. I update 1.0.1 recipe to use inc file and overwrite SRC_URI and let don't do install task.

otavio
otavio reviewed Jan 15, 2025
View reviewed changes
recipes-fsl/mcore-demos/imx-m4-demos_1.0.1.bb Outdated
SRC_URI = "${FSL_MIRROR}/${M4_SOC}-m4-freertos-${PV}.bin;fsl-eula=true"
S = "${WORKDIR}/${M4_SOC}-m4-freertos-${PV}"
SRC_URI = "${FSL_MIRROR}/${SOC}-m4-freertos-${PV}.bin;fsl-eula=true"
S = "${WORKDIR}/${SOC}-m4-freertos-${PV}.bin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried that? Because this change seems completely wrong.

Also, there is no package being generated, so it is just not generating the package to allow it to be deployed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, The S directory was typo to .bin Updated.
Yes, imx7d mcore package no elf，So no need install them to /lib/firmware

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? How would I load the firmware during the runtime of the system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These firmware was defined WKS_FILE_DEPENDS, they are installed in /run/media/boot-mmcblk1p1/mcore-demos when bootup. Although imx7d mcore no elf package, the bin package also generated and put in DEPLOYDIR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is wrong. We should allow it to be installed as the user may want to load it manually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @otavio. I'm not an expert, but maybe since these are images to run on the mcore cores in the SOC, it doesn't make sense to load them manually like regular firmware? Note also that the files that are installed are not the same as the files that are deployed. The former is always .elf, while the latter is .bin or .img. As Zelan said, there are no .elf files in the archive for 1.0.1.

@zelan-nxp
mcore-demos: Upgrade to 6.6.52_2.2.0
256cacc 
imx95: 2.16.001 -> 24.12.00

Signed-off-by: Zelan Zou <[email protected]>
@thochstein thochstein requested a review from junzhuimx January 17, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thochstein thochstein thochstein approved these changes

@otavio otavio otavio approved these changes

@junzhuimx junzhuimx Awaiting requested review from junzhuimx

Assignees
No one assigned
Labels
backport scarthgap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zelan-nxp @otavio @thochstein