Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list strings merged default and custom #51

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

imorland
Copy link
Member

No description provided.

Copy link
Member

@DavideIadeluca DavideIadeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to see a backend test, but I realize that may be out of scope to introduce testing in this PR when the existing logic is not tested

src/Api/Controllers/MergedIndexController.php Outdated Show resolved Hide resolved
@imorland
Copy link
Member Author

Yeah, agreed. I would also love to see some backend testing here, but I think that's a larger topic to plan and implement overall. Perhaps something to consider as a part of the upgrade to 2.x?

Copy link
Member

@DavideIadeluca DavideIadeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, working as expected now

@imorland imorland merged commit fb5356b into master Jan 15, 2025
10 checks passed
@imorland imorland deleted the im/merged-api branch January 15, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants