chore: add tests for PHP 8.4

FriendsOfSymfony · Nov 21, 2024 · 4bd88b6 · 4bd88b6
1 parent 4ee8732
commit 4bd88b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Builder/JsonBuilder.php b/src/Builder/JsonBuilder.php
@@ -68,7 +68,7 @@ public function getValues(): array
         return $this->values;
     }
 
-    public function setValues(array $values, string $pathPrefix = null): self
+    public function setValues(array $values, ?string $pathPrefix = null): self
     {
         foreach ($values as $key => $value) {
             $path = sprintf('%s[%s]', $pathPrefix, $key);

diff --git a/src/Installer/CKEditorInstaller.php b/src/Installer/CKEditorInstaller.php
@@ -202,7 +202,7 @@ private function getDownloadUrl(array $options): string
     /**
      * @return resource
      */
-    private function createStreamContext(callable $notifier = null)
+    private function createStreamContext(?callable $notifier = null)
     {
         $context = [];
         $proxy = getenv('https_proxy') ?: getenv('http_proxy');
@@ -306,7 +306,7 @@ private function extractFile(string $file, string $rewrite, string $origin, arra
         }
     }
 
-    private function notify(callable $notifier = null, string $type = null, mixed $data = null): mixed
+    private function notify(?callable $notifier = null, ?string $type = null, mixed $data = null): mixed
     {
         if (null !== $notifier) {
             return $notifier($type, $data);