Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pre-signature dialog before connecting WalletConnect #454

Merged
merged 20 commits into from
Jan 14, 2025
Merged

feat: add pre-signature dialog before connecting WalletConnect #454

merged 20 commits into from
Jan 14, 2025

Conversation

helciofranco
Copy link
Member

Summary

Added a pre-signature dialog to the WalletConnectConnector to inform users about the signature purpose.

📷 Demo
Screen.Recording.2025-01-08.at.00.07.57.mov

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI.
  • I've reviewed all the copies changed/added in this PR (use AI if needs help)
  • I've included the reference to the issues being closed (Github and/or Linear)
  • I've changed the Docs to reflect my changes (project setup, run commands, etc…)
  • I've put docs links where it may be helpful.

@helciofranco helciofranco self-assigned this Jan 7, 2025
@helciofranco helciofranco linked an issue Jan 7, 2025 that may be closed by this pull request
Add Pre-Signature Dialog for EVM/SVM Connection #442
Closed
@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 4:42pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.63% 143 / 232
🔵 Statements 61.63% 143 / 232
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #1337 for commit 9f9efda by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1337 for commit 9f9efda by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 24 / 24
🔵 Statements 100% 24 / 24
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1337 for commit 9f9efda by the Vitest Coverage Report Action

@helciofranco helciofranco marked this pull request as ready for review January 7, 2025 16:15
@helciofranco helciofranco enabled auto-merge (squash) January 7, 2025 17:20
LuizAsFight
LuizAsFight requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I connect, when sign step comes, I close the popup, then try connecting again, the app will not ask for signature anymore.

arthurgeron
arthurgeron previously requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@arthurgeron arthurgeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, there's only a small detail to be analyzed

packages/walletconnect-connector/src/WalletConnectConnector.ts Outdated Show resolved Hide resolved
@helciofranco helciofranco merged commit 71256d8 into main Jan 14, 2025
11 checks passed
@helciofranco helciofranco deleted the hf/feat/add-pre-signature-dialog branch January 14, 2025 06:47
@fuel-service-user fuel-service-user mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

@arthurgeron arthurgeron Awaiting requested review from arthurgeron arthurgeron is a code owner

Assignees

@helciofranco helciofranco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Pre-Signature Dialog for EVM/SVM Connection
3 participants
@helciofranco @arthurgeron @LuizAsFight