Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the 0.40.2 fix of TAI on master #2485

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Port the 0.40.2 fix of TAI on master #2485

merged 2 commits into from
Dec 9, 2024

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Dec 9, 2024 •
edited
Loading

#2476

Description

Port the fix released in 0.40.2 here

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT requested a review from a team December 9, 2024 10:18
@AurelienFT AurelienFT requested a review from a team December 9, 2024 14:07
Dentosal
Dentosal approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@Dentosal Dentosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurts that we have to do this but I see no other way. Them doing a breaking in a minor release is not nice.

@AurelienFT AurelienFT merged commit c011b71 into master Dec 9, 2024
31 checks passed
@AurelienFT AurelienFT deleted the fix_tai64_backport branch December 9, 2024 14:41
@xgreenx xgreenx mentioned this pull request Dec 26, 2024
Merged
1 task
xgreenx added a commit that referenced this pull request Dec 31, 2024
@xgreenx
Sync the version of the fuel-core with minor hot fixes (#2516)
df0283c 
Making the version in sync with
#2452 and
#2477.

One of changes already is ported to `master` -
#2485

Another one is on review -
#1922

### Before requesting review
- [x] I have reviewed the code myself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@Dentosal Dentosal Dentosal approved these changes

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @Dentosal @xgreenx