-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the rocksdb cache optional in config and add policy for column opening #2526
Open
AurelienFT
wants to merge
17
commits into
master
Choose a base branch
from
add_more_rocksdb_options
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
January 2, 2025 10:03
xgreenx
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like CI fails=)
xgreenx
reviewed
Jan 2, 2025
…s an argument anymore
xgreenx
reviewed
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache is now an option and can be enable or disabled for each rocksdb instances.
A new rocksdb config has been added to choose between the mode that open columns on database in a lazy way (useful for tests) and the mode that open all columns at once at start (useful for production and benches). Benches now use the
rocksdb-production
feature of fuel-core.In order to be more future-proof on the database configuration options, a
DatabaseConfig
structure has been created and is used across the code.Breaking change
Before, if
max-database-cache-size
was unspecified thenDEFAULT_DATABASE_CACHE_SIZE
was used.Now it make the cache disabled.
Checklist
Before requesting review