Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tx specific GTFArgs and make new generic GTFArgs to replace duplication #882

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AurelienFT
Copy link
Contributor

#812

Add new transactions specific GTFArgs, creates new GTFArgs to deprecate duplicated one between Script and Create and make them generic for all transactions implementing ExecutableTransaction.

TODO: Management of upgrade GTFArgs, tests

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@AurelienFT AurelienFT changed the title Add new GTF args for all transactions type and deprecated specific ol… Add new tx specific GTFArgs and make new generic GTFArgs to replace duplication Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant