Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

feat: improve erc deposit error #170

Merged
merged 18 commits into from
Oct 26, 2023
Merged

feat: improve erc deposit error #170

merged 18 commits into from
Oct 26, 2023

Conversation

matt-user
Copy link
Contributor

@matt-user matt-user commented Oct 20, 2023 •
edited
Loading

closes FRO-590
closes #162

@matt-user matt-user added the enhancement New feature or request label Oct 20, 2023
@matt-user matt-user self-assigned this Oct 20, 2023
@linear
Copy link

linear bot commented Oct 20, 2023

FRO-590 Feat: improve erc20 deposit error message

If a user attempts to deposit an erc20 token to fuel with no eth on the fuel side they will get an error "not enough resources to fit…". The error message instead should be something like "Error: erc20 deposit requires eth on Fuel. Please faucet/deposit eth into your fuel wallet.

this situation can be used as an opportunity to improve our e2e test

  • instead of start with deposit ETH, we can start with deposit ERC20, then wait for this error to happen, and validate its text
  • then we do the deposit ETH test
  • after deposit ETH, go back and finish deposit ERC20, now that have funds

@matt-user matt-user marked this pull request as ready for review October 25, 2023 21:33
LuizAsFight
LuizAsFight suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just minior

packages/app/playwright/e2e/Bridge.test.ts Outdated Show resolved Hide resolved
packages/app/src/systems/Chains/eth/services/txEthToFuel.ts Outdated Show resolved Hide resolved
matt-user and others added 2 commits October 26, 2023 10:14
LuizAsFight
LuizAsFight previously approved these changes Oct 26, 2023
View reviewed changes
@matt-user matt-user enabled auto-merge (squash) October 26, 2023 17:42
@matt-user matt-user requested a review from LuizAsFight October 26, 2023 17:42
@matt-user matt-user merged commit 6a773a8 into main Oct 26, 2023
@matt-user matt-user deleted the matt-user/improve-erc-deposit-error branch October 26, 2023 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck

Assignees

@matt-user matt-user

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve erc20 deposit error message
2 participants
@matt-user @LuizAsFight