-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added method to duplicate predicate #3432
base: master
Are you sure you want to change the base?
feat: added method to duplicate predicate #3432
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@YaTut1901 is attempting to deploy a commit to the Fuel Labs Team on Vercel. A member of the Team first needs to authorize it. |
@Torres-ssf @danielbate @petertonysmith94 hello, could you please check this implementation and if that fits point me which docs it should be documented in? |
CodSpeed Performance ReportMerging #3432 will degrade performances by 44.87%Comparing Summary
Benchmarks breakdown
|
Thanks for the contribution! Before we can merge this, we need @YaTut1901 to sign the Fuel Labs Contributor License Agreement. |
@YaTut1901 can you please fix the lint errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work on this @YaTut1901 🚀
@petertonysmith94 could you suggest any other issue to take? probably this #3406 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, one thought on your test grouping
packages/fuel-gauge/src/predicate/predicate-duplication.test.ts
Outdated
Show resolved
Hide resolved
hello @Torres-ssf @danielbate , may this PR be merged? |
@YaTut1901 Please make sure to request a re-review after finishing applying the requested changes |
@danielbate @petertonysmith94 approve please |
"@fuel-ts/account": patch | ||
--- | ||
|
||
feat: added method to duplicate predicate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have this ready and approved, but let's not merge it just yet.
This comment is to prevent an accidental merge.
Release notes
In this release, we:
fromInstance
to thePredicate
class.Summary
fromInstance
to thePredicate
class. This allows the consumer to create a new predicate instance with new configurable parameters and data.Checklist