Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added method to duplicate predicate #3432

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

YaTut1901
Copy link
Contributor

@YaTut1901 YaTut1901 commented Nov 29, 2024

Release notes

In this release, we:

  • Added method fromInstance to the Predicate class.

Summary

  • Added the method fromInstance to the Predicate class. This allows the consumer to create a new predicate instance with new configurable parameters and data.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 11:45am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 11:45am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 11:45am

Copy link

vercel bot commented Nov 29, 2024

@YaTut1901 is attempting to deploy a commit to the Fuel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@YaTut1901
Copy link
Contributor Author

@Torres-ssf @danielbate @petertonysmith94 hello, could you please check this implementation and if that fits point me which docs it should be documented in?

Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #3432 will degrade performances by 44.87%

Comparing YaTut1901:YaTut1901/chore/predicate-duplication-static (5f2e7a2) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master YaTut1901:YaTut1901/chore/predicate-duplication-static Change
should successfully conduct a custom transfer between wallets (x20 times) 50.3 ms 91.2 ms -44.87%

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Dec 5, 2024

Thanks for the contribution! Before we can merge this, we need @YaTut1901 to sign the Fuel Labs Contributor License Agreement.

@Dhaiwat10
Copy link
Member

@YaTut1901 can you please fix the lint errors?

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work on this @YaTut1901 🚀

@YaTut1901
Copy link
Contributor Author

YaTut1901 commented Dec 11, 2024

@petertonysmith94 could you suggest any other issue to take? probably this #3406 ?

Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👏

Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, one thought on your test grouping

@Torres-ssf Torres-ssf added feat Issue is a feature and removed chore Issue is a chore labels Dec 11, 2024
.changeset/gentle-toes-play.md Outdated Show resolved Hide resolved
@YaTut1901 YaTut1901 changed the title chore: added static method to duplicate predicate feat: added method to duplicate predicate Dec 13, 2024
@YaTut1901
Copy link
Contributor Author

hello @Torres-ssf @danielbate , may this PR be merged?

@Torres-ssf
Copy link
Contributor

hello @Torres-ssf @danielbate , may this PR be merged?

@YaTut1901 Please make sure to request a re-review after finishing applying the requested changes

@YaTut1901
Copy link
Contributor Author

@danielbate @petertonysmith94 approve please

"@fuel-ts/account": patch
---

feat: added method to duplicate predicate
Copy link
Member

@arboleya arboleya Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have this ready and approved, but let's not merge it just yet.

This comment is to prevent an accidental merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable creating a new predicate from an existing one
6 participants