Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for --fuel-core-port flag in fuels init #3531

Merged
merged 5 commits into from
Jan 3, 2025
Merged

feat: add support for --fuel-core-port flag in fuels init #3531

merged 5 commits into from
Jan 3, 2025

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Jan 3, 2025 •
edited by arboleya
Loading

Release notes

In this release, we:

  • Added support for --fuel-core-port flag in fuels init command

Summary

While working on #3528, I realized that we can't pass the --fuel-core-port flag in fuels init. I initially had the code of this PR be part of #3528, but then I split it up for organization's sake and added the text modification there as a first aid. Whichever gets merged first, I'll update the second one to remove that text modification part.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the feat Issue is a feature label Jan 3, 2025
@nedsalk nedsalk self-assigned this Jan 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:36am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:36am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:36am

@nedsalk nedsalk marked this pull request as ready for review January 3, 2025 10:01
petertonysmith94
petertonysmith94 reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Could we add an entry in the config file docs?

@nedsalk
Copy link
Contributor Author

nedsalk commented Jan 3, 2025

@petertonysmith94 there is already an entry for it.

@nedsalk nedsalk requested a review from danielbate January 3, 2025 10:27
@arboleya arboleya enabled auto-merge (squash) January 3, 2025 11:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report:

Lines Branches Functions Statements
77.78%(+0%) 70.44%(+0%) 75.37%(+0%) 77.74%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya merged commit 0fb6fa8 into master Jan 3, 2025
24 checks passed
@arboleya arboleya deleted the ns/feat/fuels-init-fuel-core-port-flag branch January 3, 2025 12:16
@fuel-service-user fuel-service-user mentioned this pull request Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for --fuel-core-port flag in fuels init
4 participants
@nedsalk @arboleya @danielbate @petertonysmith94