Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: integration test using removed flag #3534

Merged
merged 5 commits into from
Jan 3, 2025
Merged

fix: integration test using removed flag #3534

merged 5 commits into from
Jan 3, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 3, 2025 •
edited
Loading

Summary

  • Fixing integration test that is failing in CI. See passing run.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Jan 3, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:07am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:07am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:07am

@petertonysmith94 petertonysmith94 mentioned this pull request Jan 3, 2025
Closed
4 tasks
@petertonysmith94 petertonysmith94 changed the title fix: integration test fix: integration test using removed flag Jan 3, 2025
@petertonysmith94 petertonysmith94 marked this pull request as ready for review January 3, 2025 10:34
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) January 3, 2025 10:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report:

Lines Branches Functions Statements
77.78%(+0%) 70.44%(+0.04%) 75.37%(-0.01%) 77.74%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/lib/getPackageManager.ts 100%
(+0%)		 88.88%
(+8.88%)		 100%
(+0%)		 100%
(+0%)

@petertonysmith94 petertonysmith94 merged commit a9eb399 into master Jan 3, 2025
27 of 30 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/integration-test branch January 3, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-detect package manager in create fuels
4 participants
@petertonysmith94 @arboleya @danielbate @nedsalk