-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve punycode
deprecation notice
#3537
Draft
petertonysmith94
wants to merge
10
commits into
master
Choose a base branch
from
ps/chore/fix-punycode-deprecation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
petertonysmith94
commented
Jan 3, 2025
arboleya
reviewed
Jan 3, 2025
…bs/fuels-ts into ps/chore/fix-punycode-deprecation
This PR is published in NPM with version 0.0.0-pr-3537-20250103163221 |
chore: added overrides for templates
This reverts commit 18073b2.
2 tasks
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
punycode
deprecation notice #2907Summary
This PR fixes most of the
punycode
deprecation notices fornode@v22+
:Internal users
Fixed most the notices for internal users by add an override for
whatwg-url
on the pnpm workspace.master
: 311 warnings (job, raw)ps/chore/fix-punycode-deprecation
: 3 warnings (job, raw).I believe the
docs
anddocs-api
still experience this due to themarkdown-it
dependency.create fuels
usersFixed for users of
create fuels
by adding relevant overrides to the templates."Other" users
Any user using
fuels
using our package, without the overridden dependencies will experience this issue. From my investigation thegraphql-request
dependency is the primary culprit due to its reliance oncross-fetch
. As ofcross-fetch@v7
thecross-fetch
dependency has been removed, although it is also now ESM only and therefore blocking the upgrade.Checklist