-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: autoCost
for transaction estimation and funding
#3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielbate
changed the title
feat: add
feat: add Jan 3, 2025
autoCost
for script transactionsautoCost
for transactions
danielbate
changed the title
feat: add
feat!: add Jan 3, 2025
autoCost
for transactionsautoCost
for transactions
danielbate
changed the title
feat!: add
feat!: add Jan 3, 2025
autoCost
for transactionsautoCost
for transaction estimation and funding
danielbate
changed the title
feat!: add
feat!: Jan 3, 2025
autoCost
for transaction estimation and fundingautoCost
for transaction estimation and funding
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
nedsalk,
petertonysmith94 and
maschad
as code owners
January 3, 2025 17:53
Coverage Report:
Changed Files:
|
arboleya
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surgical, minimal footprint. Well done. 🎯
nedsalk
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍
petertonysmith94
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoCost
helper for transaction requests #3535Release notes
In this release, we:
autoCost
method to easily estimate and fund transactionsfundWithRequiredCoins
->autoCost
for contract and script callsSummary
Added a helper method to the
ScriptTransactionRequest
to easily estimate and fund a transaction. This allows consumers to easily bundle transactions before submission. This will form part of the optimisation docs in #3535.Breaking Changes
To be brought inline with
autoCost
, funding a contract and script call has been migrated fromfundWithRequiredCoins
toautoCost
:Checklist