Introduce a new symbol resolving pass #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
compiler
tritao
force-pushed
the
symbol-resolve-ctx
branch
6 times, most recently
from
dc45030 to
c9679b2
Compare
tritao
force-pushed
the
symbol-resolve-ctx
branch
5 times, most recently
from
a85e6de to
35c79b9
Compare
tritao
force-pushed
the
symbol-resolve-ctx
branch
3 times, most recently
from
c11ad6b to
e2578a1
Compare
tritao
force-pushed
the
symbol-resolve-ctx
branch
from
e2578a1 to
2c9c53a
Compare
tritao
force-pushed
the
symbol-resolve-ctx
branch
from
2c9c53a to
6a16d32
Compare
tritao
force-pushed
the
symbol-resolve-ctx
branch
5 times, most recently
from
ac277ac to
9f763b9
Compare
8 tasks
tritao
force-pushed
the
symbol-resolve-ctx
branch
4 times, most recently
from
dfb469f to
e9ca308
Compare
tritao
force-pushed
the
symbol-resolve-ctx
branch
3 times, most recently
from
f1416ed to
2c8dc64
Compare
jjcnn
previously approved these changes
Aug 5, 2024
tritao
force-pushed
the
symbol-resolve-ctx
branch
from
a5cb793 to
b5a1aef
Compare
|
Pushed a new commit addressing the review feedback. |
jjcnn
approved these changes
Aug 5, 2024
kayagokalp
approved these changes
Aug 6, 2024
sdankel
approved these changes
Aug 6, 2024
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Description This PR implements a new AST resolution approach that resolves symbols using the information from the collection context. To achieve this, we introduce a new `ResolveSymbols` trait and `SymbolResolveContext` context type. Parsed nodes now contain a `resolved_call_path_binding: Option<TypeBinding<ResolvedCallPath<ParsedDeclId<...>>>>`, which contain the resolved call path binding that references the `ParsedDeclId` relative to the resolved name. This field is resolved by the new `resolve_symbols` pass, which mutates the `resolved_call_path_binding` as it walks through the nodes. Most of the name lookups are implemented in the new `SymbolResolveTypeBinding` which is equivalent to the existing `TypeCheckTypeBinding` (to be removed once everything is migrated in the type checker). The only exception right now are `DelineatedPath` and `AmbiguousPathExpression` which are not being fully resolved yet (though there is a draft PR right now with some of this ongoing work). Also to note there are a handful of unused functions in the context that will be used in the next PRs. These are the main commits: [Implement Declaration::TraitFn.](8da3223) [Implement decl_engine_parsed_decl and get_parsed_decl.](dd6f5e6) [Fix lexical scope id calculation on creation.](e16d996) [Add symbol resolve context.](e9356cc) [Collect nodes inside each function body and keep a reference to their lexical scope](e327345) [Resolve alias declarations when resolving struct symbols.](2c8dc64) Partially closes #5379. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new AST resolution approach that resolves symbols using the information from the collection context.
To achieve this, we introduce a new
ResolveSymbolstrait andSymbolResolveContextcontext type.Parsed nodes now contain a
resolved_call_path_binding: Option<TypeBinding<ResolvedCallPath<ParsedDeclId<...>>>>, which contain the resolved call path binding that references theParsedDeclIdrelative to the resolved name. This field is resolved by the newresolve_symbolspass, which mutates theresolved_call_path_bindingas it walks through the nodes.Most of the name lookups are implemented in the new
SymbolResolveTypeBindingwhich is equivalent to the existingTypeCheckTypeBinding(to be removed once everything is migrated in the type checker).The only exception right now are
DelineatedPathandAmbiguousPathExpressionwhich are not being fully resolved yet (though there is a draft PR right now with some of this ongoing work).Also to note there are a handful of unused functions in the context that will be used in the next PRs.
These are the main commits:
Implement Declaration::TraitFn.
Implement decl_engine_parsed_decl and get_parsed_decl.
Fix lexical scope id calculation on creation.
Add symbol resolve context.
Collect nodes inside each function body and keep a reference to their lexical scope
Resolve alias declarations when resolving struct symbols.
Partially closes #5379.
Checklist
Breaking*orNew Featurelabels where relevant.