Add .DO support. Look inside .DSK files to detect sector order. #679
Conversation
| @@ -535,8 +551,6 @@ mediatype_t iwmDisk::mount(FILE *f, const char *filename, uint32_t disksize, med | |||
| readonly = false; | |||
There was a problem hiding this comment.
Why is the section above not duplicated to MEDIATYPE_DO?
There was a problem hiding this comment.
high_score_enabled is only ever set to true for .2MG files in MediaTypePO::mount
There was a problem hiding this comment.
I see. Thanks for the quick and helpful answer :-)
Another question I couldn't find an answer for easily: Does the new code make sure that Disk II mounting of PO media is only an option for 140kB files?
There was a problem hiding this comment.
I admit I don't really understand the high score code. I don't recall anything like that for other floppy emulators, so I assume it is a FujiNet thing?
The new code is not checking for 140kB files. I was thinking to allow up to 160kB, or anywhere between 35-40 whole tracks, since WOZ format supports up to 40. Not common but pretty easy. I could pass back MEDIATYPE_UNKNOWN from the ::mount calls if the size isn't supported.
There was a problem hiding this comment.
I'm not sure how to interpret your answer. Do you say that there's already code in place that checks for some size or do you say that you plan to add such code?
There was a problem hiding this comment.
The new code calls through to the old DSK code … as far as I can tell the DSK code does not check the size.
I am proposing to add file size checks, and support up to 40 tracks while I'm in the code.
There was a problem hiding this comment.
Thanks for the explanation :-)
|
On the Apple2, The High score code simply checks for a write request (on
something currently mounted as read-only), and if the underlying file
permissions allow it, it will honor it by re-opening the file as
read-write, writing the block, and then reopening as read-only. This is so
that high score tables can be written to disk.
…-Thom
On Mon, Oct 23, 2023 at 2:23 PM mike-wiese ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/device/iwm/disk.cpp
<#679 (comment)>
:
> @@ -535,8 +551,6 @@ mediatype_t iwmDisk::mount(FILE *f, const char *filename, uint32_t disksize, med
readonly = false;
I admit I don't really understand the high score code. I don't recall
anything like that for other floppy emulators, so I assume it is a FujiNet
thing?
The new code is not checking for 140kB files. I was thinking to allow up
to 160kB, or anywhere between 35-40 whole tracks, since WOZ format supports
up to 40. Not common but pretty easy. I could pass back MEDIATYPE_UNKNOWN
from the ::mount calls if the size isn't supported.
—
Reply to this email directly, view it on GitHub
<#679 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVBYZXIJBF7GF3UC4QWTITYA273FAVCNFSM6AAAAAA6LFZ6DOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJTGM3TMNJXHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Go fro it.
…-Thom
On Mon, Oct 23, 2023 at 6:43 PM mike-wiese ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/device/iwm/disk.cpp
<#679 (comment)>
:
> @@ -535,8 +551,6 @@ mediatype_t iwmDisk::mount(FILE *f, const char *filename, uint32_t disksize, med
readonly = false;
The new code calls through to the old DSK code … as far as I can tell the
DSK code does not check the size.
I am proposing to add file size checks, and support up to 40 tracks while
I'm in the code.
—
Reply to this email directly, view it on GitHub
<#679 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVBYZSLS22LOF3YAEIBMJDYA36K5AVCNFSM6AAAAAA6LFZ6DOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJTG4YTOMBYGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
For issue #616