-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the remainder of overlapping notes from songs #119
base: main
Are you sure you want to change the base?
Remove the remainder of overlapping notes from songs #119
Conversation
My favorite kind of PR Is there a way to apply these fixes by removing lines from the original files? That would make the diffs easier to read! |
59009de
to
9e86ec1
Compare
As much as I'd like to, the chart editor likes to reformat and reorder everything. And VSCode's diff viewer is taking forever to load so I can't even try to fix it manually. Edit: I think I got it now, currently managed to reduce the diffs on 2hot-chart by a LOT. |
19ff1c3
to
cd50a48
Compare
5c0ca7a
to
25b2ac2
Compare
Alright, finally managed to undo the "mess" the chart editor did. Diffs should be way more readable now. |
Thanks for going through all that! Also really awesome application of your overlapping note viewer :) |
Title. These only exist on the Opponent's side so they don't affect the player's experience, but I think it'd be nice to remove them anyway. Notes removed can be seen below (via the feature implemented by PR Funkin/3574).
2hot Easy
2hot-easy-notes.webm
Philly Nice Erect
philly-nice-erect.webm
Fresh Pico Mix Easy