Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the remainder of overlapping notes from songs #119

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NotHyper-474
Copy link

@NotHyper-474 NotHyper-474 commented Feb 9, 2025

Title. These only exist on the Opponent's side so they don't affect the player's experience, but I think it'd be nice to remove them anyway. Notes removed can be seen below (via the feature implemented by PR Funkin/3574).

2hot Easy
2hot-easy-notes.webm
Philly Nice Erect
philly-nice-erect.webm
Fresh Pico Mix Easy

Section 18 Section 34
fresh-pico-easy-notes1 fresh-pico-easy-notes2

@Hundrec Hundrec added status: pending triage The bug or PR has not been reviewed yet. size: large A large pull request with more than 100 changes type: charting issue Involves the charting or placement of notes for a level. labels Feb 9, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 9, 2025

My favorite kind of PR

Is there a way to apply these fixes by removing lines from the original files? That would make the diffs easier to read!

@NotHyper-474 NotHyper-474 force-pushed the patch/2hot-stacked-notes branch 2 times, most recently from 59009de to 9e86ec1 Compare February 9, 2025 03:10
@NotHyper-474
Copy link
Author

NotHyper-474 commented Feb 9, 2025

As much as I'd like to, the chart editor likes to reformat and reorder everything. And VSCode's diff viewer is taking forever to load so I can't even try to fix it manually.

Edit: I think I got it now, currently managed to reduce the diffs on 2hot-chart by a LOT.
Edit 2: Did the same with Fresh Pico Easy. It was easier than I expected since the chart editor only reordered the difficulties, so I just had to reorder them back.

@NotHyper-474 NotHyper-474 force-pushed the patch/2hot-stacked-notes branch 3 times, most recently from 19ff1c3 to cd50a48 Compare February 9, 2025 18:21
@NotHyper-474 NotHyper-474 force-pushed the patch/2hot-stacked-notes branch from 5c0ca7a to 25b2ac2 Compare February 9, 2025 18:47
@NotHyper-474
Copy link
Author

NotHyper-474 commented Feb 9, 2025

Alright, finally managed to undo the "mess" the chart editor did. Diffs should be way more readable now.
Now the large label is incorrect lol

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 9, 2025

Thanks for going through all that!

Also really awesome application of your overlapping note viewer :)

@Hundrec Hundrec added size: medium A medium pull request with 100 or fewer changes and removed size: large A large pull request with more than 100 changes labels Feb 9, 2025
@NotHyper-474 NotHyper-474 changed the title Remove a handful of overlapping notes from some songs Remove the remainder of overlapping notes from songs Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: medium A medium pull request with 100 or fewer changes status: pending triage The bug or PR has not been reviewed yet. type: charting issue Involves the charting or placement of notes for a level.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants