Editors close button fix #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and one more thing - the assets submodule could really use the PR template. I hate having to copy the template from one of my PRs on the main repo. |
Hundrec
added
type: minor bug
Noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
FunkinCrew/Funkin#2434
Briefly describe the issue(s) fixed.
The close button simply did not have an asset set - the path that it used doesn't have one. The image must of been moved at some point. I've simply copied the close image from haxe ui into the assets and made both styles for the editors use it.
Also I noticed a tiny issue with haxe ui: haxeui/haxeui-core#663